Page MenuHomeFreeBSD

ipfw(8): Fix most warnings with the default WARNS level.
ClosedPublic

Authored by markj on Jun 25 2020, 7:25 PM.
Tags
None
Referenced Files
F132141172: D25456.id73651.diff
Tue, Oct 14, 3:14 AM
Unknown Object (File)
Sun, Oct 5, 11:19 PM
Unknown Object (File)
Sun, Oct 5, 6:36 AM
Unknown Object (File)
Wed, Oct 1, 8:49 AM
Unknown Object (File)
Sep 7 2025, 6:09 PM
Unknown Object (File)
Aug 21 2025, 2:39 AM
Unknown Object (File)
Aug 14 2025, 8:01 PM
Unknown Object (File)
Aug 10 2025, 7:17 PM
Subscribers

Details

Summary

Most of these fall into one of several patterns.


- Missing const qualifiers. All but one of these were benign (i.e.,
adding "const" fixes the warning). The exception was in print_ip(),
where we write

cmd->addr.s_addr = htonl(cmd->addr.s_addr);
<print statement>
cmd->addr.s_addr = htonl(cmd->addr.s_addr);


so this can easily be fixed with a temporary variable.

- A global variable `co` shadowing local declarations. In ipfw2.c, some
code gets `co` through a function parameter for some reason. I
renamed the global `co` to `g_co`. I think this will help a bit if
anyone ever tries to convert this code to a libipfw.

- Using a signed int as an index variable where the loop bound is
unsigned. I just converted the variable to have the same type as the
bound.

- Missing static qualifiers on some functions.

- I left the -Wcast-align warnings alone. They are more involved to
fix. It might be sufficient to just add an __aligned qualifier to the
corresponding kernel types.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable