Page MenuHomeFreeBSD

Enable long double tests on RISC-V
ClosedPublic

Authored by mhorne on Jun 23 2020, 8:31 PM.
Tags
None
Referenced Files
F132203842: D25419.id73544.diff
Tue, Oct 14, 6:28 PM
F132191303: D25419.id.diff
Tue, Oct 14, 3:32 PM
F132191301: D25419.id73570.diff
Tue, Oct 14, 3:32 PM
F132191295: D25419.id73546.diff
Tue, Oct 14, 3:32 PM
F132191294: D25419.id73544.diff
Tue, Oct 14, 3:32 PM
F132155535: D25419.diff
Tue, Oct 14, 6:47 AM
Unknown Object (File)
Tue, Oct 14, 2:12 AM
Unknown Object (File)
Fri, Oct 10, 5:26 AM
Subscribers

Details

Reviewers
ngie
Group Reviewers
riscv
Commits
rS362576: Enable long double tests on RISC-V
Summary

Some of the NetBSD contributed tests are gated behind the
__HAVE_LONG_DOUBLE flag. This flag seems to be defined only for
platforms whose long double is larger than their double. I could not
find this explicitly documented anywhere, but it is implied by the
definitions in NetBSD's sys/arch/${arch}/include/math.h headers, and the
following assertion from the ubsan code:

#ifdef __HAVE_LONG_DOUBLE
    ASSERT(sizeof(LD) > sizeof(uint64_t));
#endif

RISC-V has 128-bit long doubles, so enable the tests on this platform,
and update the comments to better explain the purpose of this flag.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne created this revision.
jrtc27 added inline comments.
lib/libc/tests/stdlib/Makefile
23 ↗(On Diff #73544)

This comment wasn't updated

Update comment in tests/stdlib/Makefile.

This revision is now accepted and ready to land.Jun 24 2020, 3:32 AM
This revision was automatically updated to reflect the committed changes.