Page MenuHomeFreeBSD

Enable long double tests on RISC-V
ClosedPublic

Authored by mhorne on Jun 23 2020, 8:31 PM.

Details

Reviewers
ngie
Group Reviewers
riscv
Commits
rS362576: Enable long double tests on RISC-V
Summary

Some of the NetBSD contributed tests are gated behind the
__HAVE_LONG_DOUBLE flag. This flag seems to be defined only for
platforms whose long double is larger than their double. I could not
find this explicitly documented anywhere, but it is implied by the
definitions in NetBSD's sys/arch/${arch}/include/math.h headers, and the
following assertion from the ubsan code:

#ifdef __HAVE_LONG_DOUBLE
    ASSERT(sizeof(LD) > sizeof(uint64_t));
#endif

RISC-V has 128-bit long doubles, so enable the tests on this platform,
and update the comments to better explain the purpose of this flag.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mhorne created this revision.
jrtc27 added inline comments.
lib/libc/tests/stdlib/Makefile
23 ↗(On Diff #73544)

This comment wasn't updated

Update comment in tests/stdlib/Makefile.

This revision is now accepted and ready to land.Jun 24 2020, 3:32 AM
This revision was automatically updated to reflect the committed changes.