Details
- Reviewers
gjb wblock - Commits
- rD46893: Catch up with newly created macros.
Diff Detail
- Repository
- rD FreeBSD doc repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Looks okay, but shouldn't the whole list be alphabetical? CPAN is out of place, for a start.
I hoped no one would notice that ?
It's because CPAN is short for PERL_CPAN, as SF is short for SOURCEFORGE, but I replaced the long forms with the short form at one point, and forgot to reorder…
Maybe it's time to add a third column to the table for a note or reference that shows what that particular macro applies to or when it is used.
This is nice. I was just thinking of a third column on the existing table, which could have the shorter version:
| Macro | Alternate Name | Assumed subdirectory |
| PERL_CPAN | CPAN | ${PORTNAME:C/-.*//} |
| SAMBA | ${PORTNAME} | |
That might make it easier to find the shorter versions, because they are right with the long one. However, whichever way you want to do it is fine.
| en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml | ||
|---|---|---|
| 1695 ↗ | (On Diff #5402) | s/shortcut/shortcuts/ |
| 1699 ↗ | (On Diff #5402) | s/Shortcut/Shortcuts/ |
I started with doing just that, but then, half the shortcuts are not magic macros, only short versions (like RUBYGEMS -> RG), and it did not feel right to put them in the magic section.
| en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml | ||
|---|---|---|
| 1760 ↗ | (On Diff #6089) | That should probably be <quote> to imply it's not really magic, rather than emphasis. |
| 1763 ↗ | (On Diff #6089) | "try to guess" sounds really unsure. "attempt to use" still admits that it might not work, but sounds a little better. |
| 1770 ↗ | (On Diff #6089) | s/Will infer/infers/ (not capitalized, it's still part of the previous sentence.) |
| 1772 ↗ | (On Diff #6089) | s/guess/inferred directory/ |
| en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml | ||
|---|---|---|
| 1763 ↗ | (On Diff #6472) | Did you mean "safe"? Probably not needed at all. "use" is redundant with the one earlier in the sentence. How about "...choose a subdirectory automatically."? |
| en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml | ||
|---|---|---|
| 1763 ↗ | (On Diff #6472) | Mmm, no, it was supposed to be "sane". Let's change it to what you propose. |
Looks good to me. Please check with igor -Rz and build-test before commit. (You know this, I'm just trying to get in the habit of saying it.)