Page MenuHomeFreeBSD
Differential D2537

Delete armv7_sleep which duplicates armv7_cpu_sleep
ClosedPublic
Actions

Authored by john-feith.com on May 14 2015, 3:52 AM.
Tags
Referenced Files
Unknown Object (File)
Tue, Sep 8, 7:39 AM
Unknown Object (File)
Thu, Sep 3, 2:57 PM
Unknown Object (File)
Tue, Sep 1, 7:12 PM
Unknown Object (File)
Tue, Sep 1, 2:31 PM
Unknown Object (File)
Tue, Sep 1, 6:20 AM
Unknown Object (File)
Mon, Aug 31, 7:36 PM
Unknown Object (File)
Sun, Aug 30, 2:49 PM
Unknown Object (File)
Sun, Aug 30, 1:00 PM
View All Files
Subscribers
andrew
imp

Details

Reviewers
ganbold
andrew
• ian
Summary

armv7_sleep appears to be a duplication of armv7_cpu_sleep.

For consistency with the naming conventions used by the other
implementations kill armv7_sleep and keep armv7_cpu_sleep.

Test Plan

Smoke tested on the ODROID-C1 (Amlogic aml8726-m8b).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

john-feith.com updated this revision to Diff 5369.May 14 2015, 3:52 AM
john-feith.com retitled this revision from to Delete armv7_sleep which duplicates armv7_cpu_sleep.
john-feith.com updated this object.
john-feith.com edited the test plan for this revision. (Show Details)
john-feith.com added a reviewer: ganbold.
john-feith.com set the repository for this revision to rS FreeBSD src repository - subversion.
john-feith.com added a project: ARM.
Herald added subscribers: imp, andrew. · View Herald TranscriptMay 14 2015, 3:52 AM
ganbold added reviewers: • ian, andrew.May 14 2015, 3:55 AM
andrew accepted this revision.May 14 2015, 12:27 PM
andrew edited edge metadata.
This revision is now accepted and ready to land.May 14 2015, 12:27 PM
• ian accepted this revision.May 14 2015, 1:50 PM
• ian edited edge metadata.

I've been meaning to do this for months (I think it was me who introduced the dup).

ganbold accepted this revision.May 15 2015, 12:40 AM
ganbold closed this revision.
ganbold edited edge metadata.

Revision Contents
Changeset List

PathSize
sys/
arm/
arm/
2 lines
6 lines
include/
1 line

Diff 5369

View Options

sys/arm/arm/cpufunc.c

Loading...
View Options

sys/arm/arm/cpufunc_asm_armv7.S

Loading...
View Options

sys/arm/include/cpufunc.h

Loading...