Make vipw error message less cryptic
ClosedPublic
Actions

Authored by pstef on Jun 20 2020, 1:10 AM.

Details

Reviewers

rpokala
emaste

Commits

rS362430: Make vipw error message less cryptic

Summary

Unable to find an editor, vipw would give this error:

# env EDITOR=fnord vipw
vipw: pw_edit(): No such file or directory

vigr or crontab do better:

# env EDITOR=fnord crontab -e
crontab: no crontab for root - using an empty one
crontab: fnord: No such file or directory
crontab: "fnord" exited with status 1

After this change, vipw behaves more like vigr or crontab:

# env EDITOR=fnord vipw
vipw: fnord: No such file or directory
vipw: "fnord" exited with status 1

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pstef requested review of this revision.Jun 20 2020, 1:10 AM

pstef created this revision.

pstef edited the summary of this revision. (Show Details)

Seems reasonable.

This revision is now accepted and ready to land.Jun 20 2020, 1:18 AM

emaste accepted this revision.Jun 20 2020, 1:28 AM

emaste added a subscriber: emaste.

emaste added inline comments.

lib/libutil/pw_util.c
312 ↗	(On Diff #73361)	this seems slightly unusual, typical would be `err(1, "setgid");` I think

Closed by commit rS362430: Make vipw error message less cryptic (authored by pstef). · Explain WhyJun 20 2020, 6:20 AM

This revision was automatically updated to reflect the committed changes.

pstef added a commit: rS362430: Make vipw error message less cryptic.

Herald added a subscriber: imp. · View Herald TranscriptJun 20 2020, 6:20 AM

Revision Contents
Changeset List

Path

Size

head/

lib/

libutil/

pw_util.c

13 lines

Diff 73366

View Options

head/lib/libutil/pw_util.c

Make vipw error message less crypticClosedPublicActions