Fix a double unlock in vm_object_backing_collapse_wait().
ClosedPublic
Actions

Authored by markj on Jun 17 2020, 6:30 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 6, 3:54 PM

	Unknown Object (File)
	Mon, May 4, 5:33 PM

	Unknown Object (File)
	Fri, Apr 24, 11:27 AM

	Unknown Object (File)
	Mon, Apr 20, 8:40 AM

	Unknown Object (File)
	Mon, Apr 20, 4:19 AM

	Unknown Object (File)
	Sun, Apr 19, 11:00 PM

	Unknown Object (File)
	Sun, Apr 19, 9:33 AM

	Unknown Object (File)
	Apr 17 2026, 7:24 AM

View All 93 Files

Subscribers

imp

Details

Reviewers

jeff
alc
kib

Commits

rS362360: Fix a double object unlock in vm_object_backing_collapse_wait().

Summary

vm_object_pip_sleep() will release the lock, I believe. I noticed this
by code inspection, so I'm not certain that this code is reachable.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj requested review of this revision.Jun 17 2020, 6:30 PM

markj created this revision.

markj added reviewers: jeff, alc, kib.Jun 17 2020, 6:42 PM

Harbormaster completed remote builds in B31779: Diff 73231.Jun 18 2020, 9:20 AM

It should be very hard to provoke this situation, but I believe it is real.

This revision is now accepted and ready to land.Jun 18 2020, 11:44 PM

Closed by commit rS362360: Fix a double object unlock in vm_object_backing_collapse_wait(). (authored by markj). · Explain WhyJun 19 2020, 3:32 AM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS362360: Fix a double object unlock in vm_object_backing_collapse_wait()..

Herald added a subscriber: imp. · View Herald TranscriptJun 19 2020, 3:32 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

vm/

vm_object.c

1 line

Diff 73310

View Options

Fix a double unlock in vm_object_backing_collapse_wait().ClosedPublicActions