Page MenuHomeFreeBSD

misc/xiphos: Update to 4.2.1
ClosedPublic

Authored by salvadore on Jun 17 2020, 1:13 PM.

Details

Summary

While here, also switch WWW to https.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

salvadore created this revision.Jun 17 2020, 1:13 PM
salvadore requested review of this revision.Jun 17 2020, 1:13 PM
tcberner requested changes to this revision.Jun 17 2020, 1:25 PM
tcberner added inline comments.
head/misc/xiphos/Makefile
44

I don't quite understand the issue. Why are you not using the proper release tar ball which includes said file?

https://github.com/crosswire/xiphos/releases/tag/4.2.1

e.g. xiphos-4.2.1.tar.xz

This revision now requires changes to proceed.Jun 17 2020, 1:25 PM
salvadore added inline comments.Jun 17 2020, 1:42 PM
head/misc/xiphos/Makefile
44

I could not find a way to get such file using USE_GITHUB. If it is possible to do it of course I would be glad to do it.

Otherwise I think the choice is between:

  • creating the missing the file manually;
  • drop USE_GITHUB and manually specify MASTER_SITES and DISTFILES.

I choosed the first solution as it looked cleaner to me.

Use the release file instead of patching the sources downloaded with USE_GITHUB, as suggested by tcberner.

gerald accepted this revision.Jun 19 2020, 6:35 AM

I believe this is ready to land?

This revision was not accepted when it landed; it landed in state Needs Review.Jun 19 2020, 5:37 PM
This revision was automatically updated to reflect the committed changes.