lang/ecl: Fix r538595
ClosedPublic
Actions

Authored by salvadore on Jun 12 2020, 11:39 AM.

Tags

None

Referenced Files

	F153473909: D25244.id73019.diff
	Tue, Apr 21, 9:04 AM

	F153472911: D25244.id73018.diff
	Tue, Apr 21, 8:56 AM

	F153472832: D25244.id73018.diff
	Tue, Apr 21, 8:56 AM

	Unknown Object (File)
	Mon, Apr 20, 1:41 AM

	Unknown Object (File)
	Sat, Apr 18, 10:26 PM

	Unknown Object (File)
	Sat, Mar 28, 8:08 AM

	Unknown Object (File)
	Mar 6 2026, 3:36 AM

	Unknown Object (File)
	Jan 15 2026, 10:49 PM

View All Files

Subscribers

None

Details

Reviewers

mat
thierry
olgeni
gerald
tcberner

Commits

rP538656: lang/ecl: Fix r538595

Summary

Move the comment introduced in r538595 so that it does not break the port anymore.

Reported by: mat

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

salvadore requested review of this revision.Jun 12 2020, 11:39 AM

salvadore created this revision.

Harbormaster completed remote builds in B31661: Diff 73018.Jun 12 2020, 11:39 AM

This time I have tested it properly in a poudriere jail. (Only one, I hope it's enough.)

Sorry, I forgot about a warning from mat: line 11 is now part of the comment started at line 10.
I have to look at this review again.

I moved the comment from within the patch to the top of it: it is a different style than the one used by Thierry for the other patches he introduced, but I think it makes more sense in this case.

Tested successfully with poudriee i386 11.3-RELEASE.

Harbormaster completed remote builds in B31662: Diff 73019.Jun 12 2020, 12:52 PM

looks ok to me

lgtm

This revision is now accepted and ready to land.Jun 13 2020, 9:19 AM

Closed by commit rP538656: lang/ecl: Fix r538595 (authored by salvadore). · Explain WhyJun 13 2020, 9:26 AM

This revision was automatically updated to reflect the committed changes.

salvadore added a commit: rP538656: lang/ecl: Fix r538595.

Revision Contents
Changeset List

Path

Size

head/

lang/

ecl/

files/

extra-patch-src_Makefile.in

4 lines

Diff 73063

View Options

head/lang/ecl/files/extra-patch-src_Makefile.in

lang/ecl: Fix r538595ClosedPublicActions