Differential D25220

Add tests for "add", "change" and "delete" functionality of /sbin/route.
ClosedPublic
Actions

Authored by ahsanb on Jun 10 2020, 10:18 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 6, 2:15 PM

	Unknown Object (File)
	Wed, Oct 30, 3:52 PM

	Unknown Object (File)
	Tue, Oct 29, 11:14 AM

	Unknown Object (File)
	Fri, Oct 25, 1:57 PM

	Unknown Object (File)
	Oct 18 2024, 8:32 AM

	Unknown Object (File)
	Oct 1 2024, 1:24 PM

	Unknown Object (File)
	Sep 30 2024, 4:36 AM

	Unknown Object (File)
	Sep 30 2024, 12:49 AM

View All 94 Files

Subscribers

Details

Reviewers

kp
thj

Commits

rS363417: Add tests for "add", "change" and "delete" functionality of /sbin/route.

Summary

This revision includes the tests for the route utility. The tests cover the add, change and delete functionality of a route.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

ahsanb created this revision.Jun 10 2020, 10:18 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 10 2020, 10:18 PM

ahsanb requested review of this revision.Jun 10 2020, 10:18 PM

kp accepted this revision.Jun 17 2020, 9:26 AM

This revision is now accepted and ready to land.Jun 17 2020, 9:26 AM

thj accepted this revision.Jun 21 2020, 10:33 AM

Added the v6 tests.

This revision now requires review to proceed.Jun 21 2020, 9:15 PM

Replace ipv6 ULA addresses with the documentation/example ipv6 addresses

thj added inline comments.Jul 13 2020, 7:58 PM

sbin/route/tests/basic.sh
90	I think we need to use IPv6 Unique Local Addresses for tests and not documentation addresses. The pass_block.sh test from last year has an example of these. https://github.com/freebsd/freebsd/blob/master/tests/sys/netpfil/common/pass_block.sh#L88 This applies to all v6 addresses used in this test

thj accepted this revision.Jul 22 2020, 6:48 AM

thj added inline comments.

sbin/route/tests/basic.sh
90	We have decided to use documentation addresses for all network tests so this comment can be struck

This revision is now accepted and ready to land.Jul 22 2020, 6:48 AM

Closed by commit rS363417: Add tests for "add", "change" and "delete" functionality of /sbin/route. (authored by thj). · Explain WhyJul 22 2020, 1:50 PM

This revision was automatically updated to reflect the committed changes.

thj added a commit: rS363417: Add tests for "add", "change" and "delete" functionality of /sbin/route..

Revision Contents
Changeset List

Path

Size

etc/

mtree/

2 lines

sbin/

route/

3 lines

tests/

11 lines

125 lines

47 lines

Diff 73668

etc/mtree/BSD.tests.dist

Loading...

sbin/route/Makefile

Loading...

sbin/route/tests/Makefile

Loading...

sbin/route/tests/basic.sh

Loading...

sbin/route/tests/utils.subr

Loading...