Page MenuHomeFreeBSD

Add tests for "add", "change" and "delete" functionality of /sbin/route.
ClosedPublic

Authored by ahsanb on Jun 10 2020, 10:18 PM.

Details

Summary

This revision includes the tests for the route utility. The tests cover the add, change and delete functionality of a route.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Jun 17 2020, 9:26 AM
This revision now requires review to proceed.Jun 21 2020, 9:15 PM

Replace ipv6 ULA addresses with the documentation/example ipv6 addresses

sbin/route/tests/basic.sh
90 ↗(On Diff #73668)

I think we need to use IPv6 Unique Local Addresses for tests and not documentation addresses. The pass_block.sh test from last year has an example of these.

https://github.com/freebsd/freebsd/blob/master/tests/sys/netpfil/common/pass_block.sh#L88

This applies to all v6 addresses used in this test

thj added inline comments.
sbin/route/tests/basic.sh
90 ↗(On Diff #73668)

We have decided to use documentation addresses for all network tests so this comment can be struck

This revision is now accepted and ready to land.Jul 22 2020, 6:48 AM