libusb: improve compatibility

[kevans]

Summary

Specifically, add LIBUSB_CLASS_PHYSICAL and the libusb_has_capability API. Descriptions and functionality for these derived from the documentation at [0].

[0] http://libusb.sourceforge.net/api-1.0/group__libusb__misc.html

As far as I can tell, all of these capabilities are unconditionally OK with our libusb. LIBUSB_CAP_HAS_CAPABILITY has been noted as 'silly' by others because you can't realistically call libusb_has_capability(LIBUSB_CAP_HAS_CAPABILITY) -> you'll get a failure if it's provided, and... a crash, almost certainly, if it's not and something hinky has happened.

The #define for LIBUSB_CLASS_PHYSICAL has been added as a temporary compat shim so that the port that needed it (FreeRDP) can continue to build on -CURRENT in the interim. I will remove it within a couple days, just before MFC and getting __FreeBSD_version values set in stone to be added to the port in lieu of the current #ifdef LIBUSB_CLASS_PHYSICAL.

[• hselasky]

lib/libusb/libusb.h

79 ↗

(On Diff #72845)

I think you don't need this.

lib/libusb/libusb10.c

1725 ↗

(On Diff #72845)

Style, switch and case keyword on same line.

[• hselasky]

lib/libusb/libusb.h

79 ↗

(On Diff #72845)

There is no harm if ports re-define this value.

[kevans]

lib/libusb/libusb.h

79 ↗

(On Diff #72845)

Whoops, true enough- it'll resolve to the literal 5 and no worries.

[• hselasky]

lib/libusb/libusb10.c

1725 ↗

(On Diff #72845)

is same "s/line/column"

[kevans]

Fix style and remove useless non-compat shim

[• hselasky]

MFC after: 1 week

If you need help MFC-ing (9 through 12), just ship it to me!

[• hselasky]

You might also want to update the manual page for libusb 1.0 and add an MLINK for the new function.

[kevans]

Fixed a typo in a comment and added the relevant manpage bits.

I might enlist your help on MFC'ing, if you want stable/{9,10}.

[• hselasky]

Perfect.

[kevans]

Thanks! I added, with appropriate line-breaks, locally: This function will return non-zero if the given capability is supported, 0 if it is not supported. after "This function checks the runtime capabilities of .Nm" to clarify the return value. I'll plan on committing this later today.