Adjust crypto_apply function callbacks for OCF.

[jhb]

Summary

• crypto_apply() is only used for reading a buffer to compute a digest, so change the data pointer to a const pointer.

• To better match m_apply(), change the data pointer type to void * and the length from uint16_t to u_int. The length field in particular matters as none of the apply logic was splitting requests larger than UINT16_MAX.

• Adjust the auth_xform Update callback to match the function prototype passed to crypto_apply() and crypto_apply_buf(). This removes the needs for casts when using the Update callback.

• Change the Reinit and Setkey callbacks to also use a u_int length instead of uint16_t.

• Update auth transforms for the changes. While here, use C99 initializers for auth_hash structures and avoid casts on callbacks.

Test Plan

• cryptocheck -a mac -d soft -z was failing for larger gmac requests due to the UINT16_MAX rollover (others happened to still work b/c I think the uint16_t value was actually passed through as a u_int in the register and the final function ended up taking an int instead of a uint16_t) but now works

[cem]

sys/crypto/aesni/aesni.h

66 ↗

(On Diff #72782)

This is a bit bikesheddy, so feel free to ignore.

As long as we're revamping this interface, why not use unsigned in place of our non-standard (and not especially popular outsize freebsd) u_int? It's not all that much longer and it's a basic C89 type.

sys/opencrypto/xform_gmac.c

78 ↗

(On Diff #72782)

final commas for consistency with other initializers?

[jhb]

sys/crypto/aesni/aesni.h

66 ↗

(On Diff #72782)

In this case, the m_apply() hook takes a u_int for the third argument so staying consistent with m_apply means sticking with u_int.

[cem]

sys/crypto/aesni/aesni.h

66 ↗

(On Diff #72782)

I think we can be satisfied that the types are identical; this is more about using a standard spelling that isn't a typedef. I wouldn't let concerns about m_apply's parameter influence this API.

(I'd also rototill m_apply in an ideal world, but don't have much motivation to work on the network side of things.)

Anyway, I'll drop it :-).

[jhb]

• Add trailing commas.