[new port] games/lolcat, a high performance C implementation of the famous lolcat

[gbe]

Summary

Add a port of lolcat, a high performance C implementation of the famous lolcat

Test Plan

make && make install

[tcberner]

Moin moin

This needs to be wired into games/Makefile too.

mfg Tobias

games/lolcat/Makefile

4

git describe --tags a83e59dc25ba5430f7f79376d7c0f432ce27a6fe                                                                                                                                                                                                                             v1.0-9-ga83e59d

So this could be

DISTVERSIONPREFIX= v
DISTVERSION=1.0-9
DISTVERSIONSUFFIX= -ga83e59d

See [1] for more details.

[1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-ex5 example 5.14

13

^is redundant (same as portname)

14

^ this can be removed, if you do the above distversion handling

games/lolcat/pkg-descr

3

pkg-descr should contain a WWW: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-desc.html

[gbe]

• Add changes from the tcberner's feedback

[gbe]

Mark findings as done.

[tcberner]

Thanks for the changes so far.

games/lolcat/Makefile

17

^DIST* variables belong in the first block :)

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-order.html#porting-order-portname

[gbe]

• Move DIST* make directives to the top and add a LICENSE block while here

[gbe]

games/lolcat/Makefile

17

Ah, I missed this while I only had a quick read over the handbook. I correct this and upload a correct differential. Thank. :)

[gbe]

@tcberner ping?

[tcberner]

Moin moin

There are two more issues:

Firstly:

[00:00:03] Warning: MOVED: games/lolcat renamed to games/rubygem-lolcat

Apparently there was previously a ruby-port with the same name which was later moved
=> You need to modify the MOVED file too.

Secondly:

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: /censor
Error: Orphaned: /lolcat

So it seems the port does not yet install files to the proper locations.

mfg Tobias

[pizzamig]

Few changes are needed to make portlint happy

games/lolcat/Makefile

5

CATEGORIES has to be places after all the DISTVERSION variables

6

This empty line has to be removed

12

porlint suggests to remove the initial 'A'. The comment could just be:
"High performance implementation of the famous lolcat"

[gbe]

• Fix portlint -A warnings and use my FreeBSD e-mail for the maintainership

[tcberner]

That leaves the

• MOVED : remove entry
• games/Makefile : add SUBDIR = lolcat
• games/lolcat/Makefile fix up DESTDIR handling (lolcats Makefile uses DESTDIR which collides with DESTDIR from ports framework)

[pizzamig]

LGTM!
I'll work on the additional issue before commit it

[gbe]

Committed in r542049.

@pizzamig thanks for working on the port to get it commit ready.