Differential D25080

Rename DEBUG to DPRINTF
ClosedPublic
Actions

Authored by oskar.holmlund_ohdata.se on May 30 2020, 10:38 PM.

Details

Reviewers

manu

Commits

rS362417: MFC r361964:
rS361964: coufreq_dt: Rename DEBUG to DPRINTF

Summary

DEBUG is a kernel configuration flag and if used cpufreq_dt.c will fail the build of kernel.

Test Plan

Build kernel with / without DEBUG flag. I defined it in sys/arm/conf/std.armv7.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

oskar.holmlund_ohdata.se created this revision.May 30 2020, 10:38 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 30 2020, 10:38 PM

oskar.holmlund_ohdata.se requested review of this revision.May 30 2020, 10:38 PM

manu added inline comments.May 31 2020, 3:25 PM

sys/dev/cpufreq/cpufreq_dt.c
54 ↗	(On Diff #72464)	Can you leave the if 0 ? I don't like having those printfs if debug is set.

Change to #if 0 instead of #ifdef DEBUG as suggested from EmmanuelVadot

manu accepted this revision.Jun 9 2020, 9:41 AM

This revision is now accepted and ready to land.Jun 9 2020, 9:41 AM

Closed by commit rS361964: coufreq_dt: Rename DEBUG to DPRINTF (authored by manu). · Explain WhyJun 9 2020, 9:42 AM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rS361964: coufreq_dt: Rename DEBUG to DPRINTF.

manu added a commit: rS362417: MFC r361964:.Jun 19 2020, 7:33 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

cpufreq/

cpufreq_dt.c

45 lines

Diff 72853

View Options

head/sys/dev/cpufreq/cpufreq_dt.c

Rename DEBUG to DPRINTFClosedPublicActions