linuxkpi: Add kstrtou16
ClosedPublic
Actions

Authored by manu on May 25 2020, 9:07 AM.

Details

Reviewers

• hselasky
emaste

Commits

rS361551: linuxkpi: Add kstrtou16

Summary

This function convert a char * to a u16.
Simply use strtoul and cast to compare for ERANGE

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

manu created this revision.May 25 2020, 9:07 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 25 2020, 9:07 AM

manu requested review of this revision.May 25 2020, 9:07 AM

ping

• hselasky added inline comments.May 27 2020, 9:51 AM

sys/compat/linuxkpi/common/include/linux/kernel.h
380 ↗	(On Diff #72221)	temp should be unsigned long. Else the point of comparing temp != (u16)temp goes away,.

• hselasky added inline comments.May 27 2020, 9:55 AM

sys/compat/linuxkpi/common/include/linux/kernel.h
382 ↗	(On Diff #72221)	And also the (u16) cast should be removed.

manu updated this revision to Diff 72310.May 27 2020, 10:00 AM

manu edited the summary of this revision. (Show Details)

manu marked 2 inline comments as done.May 27 2020, 10:03 AM

• hselasky accepted this revision.May 27 2020, 10:18 AM

This revision is now accepted and ready to land.May 27 2020, 10:18 AM

Closed by commit rS361551: linuxkpi: Add kstrtou16 (authored by manu). · Explain WhyMay 27 2020, 11:42 AM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rS361551: linuxkpi: Add kstrtou16.

manu mentioned this in rS364672: MFC r361450, r361452, r361550-r361551.Aug 24 2020, 1:14 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

compat/

linuxkpi/

common/

include/

linux/

kernel.h

18 lines

Diff 72316

View Options

head/sys/compat/linuxkpi/common/include/linux/kernel.h

linuxkpi: Add kstrtou16ClosedPublicActions