Page MenuHomeFreeBSD
Differential D24996

linuxkpi: Add kstrtou16
ClosedPublic
Actions

Authored by manu on May 25 2020, 9:07 AM.
Tags
None
Referenced Files
F113963376: D24996.id72221.diff
Sun, Apr 6, 6:22 AM
Unknown Object (File)
Wed, Mar 26, 5:37 PM
Unknown Object (File)
Fri, Mar 7, 4:46 PM
Unknown Object (File)
Feb 23 2025, 12:32 PM
Unknown Object (File)
Feb 15 2025, 7:04 PM
Unknown Object (File)
Feb 15 2025, 6:43 PM
Unknown Object (File)
Feb 15 2025, 10:02 AM
Unknown Object (File)
Feb 14 2025, 4:09 PM
View All 55 Files
Subscribers
imp

Details

Reviewers
• hselasky
emaste
Commits
rS361551: linuxkpi: Add kstrtou16
Summary

This function convert a char * to a u16.
Simply use strtoul and cast to compare for ERANGE

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

manu created this revision.May 25 2020, 9:07 AM
Herald added a subscriber: imp. · View Herald TranscriptMay 25 2020, 9:07 AM
manu requested review of this revision.May 25 2020, 9:07 AM
manu added a comment.May 27 2020, 9:32 AM

ping

• hselasky added inline comments.May 27 2020, 9:51 AM
sys/compat/linuxkpi/common/include/linux/kernel.h
380 ↗(On Diff #72221)

temp should be unsigned long. Else the point of comparing temp != (u16)temp goes away,.

• hselasky added inline comments.May 27 2020, 9:55 AM
sys/compat/linuxkpi/common/include/linux/kernel.h
382 ↗(On Diff #72221)

And also the (u16) cast should be removed.

manu updated this revision to Diff 72310.May 27 2020, 10:00 AM
manu edited the summary of this revision. (Show Details)
manu marked 2 inline comments as done.May 27 2020, 10:03 AM
• hselasky accepted this revision.May 27 2020, 10:18 AM
This revision is now accepted and ready to land.May 27 2020, 10:18 AM
Closed by commit rS361551: linuxkpi: Add kstrtou16 (authored by manu). · Explain WhyMay 27 2020, 11:42 AM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rS361551: linuxkpi: Add kstrtou16.
manu mentioned this in rS364672: MFC r361450, r361452, r361550-r361551.Aug 24 2020, 1:14 PM

Revision Contents
Changeset List

PathSize
head/
sys/
compat/
linuxkpi/
common/
include/
linux/
18 lines

Diff 72316

View Options

head/sys/compat/linuxkpi/common/include/linux/kernel.h

# $FreeBSD$ # $FreeBSD$
PORTNAME= rdoc PORTNAME= rdoc
PORTVERSION= 4.3.0 PORTVERSION= 6.0.4
PORTREVISION= 1
CATEGORIES= devel rubygems CATEGORIES= devel rubygems
MASTER_SITES= RG MASTER_SITES= RG
MAINTAINER= ruby@FreeBSD.org MAINTAINER= ruby@FreeBSD.org
COMMENT= RDoc produces HTML and command-line documentation for Ruby projects COMMENT= RDoc produces HTML and command-line documentation for Ruby projects
LICENSE= GPLv2 RUBY LICENSE= GPLv2 RUBY
LICENSE_COMB= dual LICENSE_COMB= dual
LICENSE_FILE_RUBY= ${WRKSRC}/LICENSE.rdoc LICENSE_FILE_RUBY= ${WRKSRC}/LICENSE.rdoc
NO_ARCH= yes
USE_RUBY= yes
USES= gem USES= gem
USE_RUBY= yes
NO_ARCH= yes
post-install: post-install:
${RM} ${STAGEDIR}${PREFIX}/bin/rdoc ${STAGEDIR}${PREFIX}/bin/ri ${RM} ${STAGEDIR}${PREFIX}/bin/rdoc ${STAGEDIR}${PREFIX}/bin/ri
.include <bsd.port.mk> .include <bsd.port.mk>