sysutils/etc_os-release: fallback to uname if freebsd-version not found
ClosedPublic
Actions

Authored by lwhsu on May 25 2020, 7:01 AM.

Details

Reviewers

tcberner

Commits

rP537499: Fallback to uname(1) if freebsd-version(1) is not found

Summary

On 11, there is no freebsd-version, fallback to uname.

Discovered by:

https://lists.freebsd.org/pipermail/freebsd-ports/2020-May/118597.html

sh: freebsd-version: not found
make[5]: "/home/indexbuild/tindex/ports/sysutils/etc_os-release/Makefile" line 18: warning: "freebsd-version -u" returned non-zero status

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lwhsu created this revision.May 25 2020, 7:01 AM

Herald added a subscriber: mat. · View Herald TranscriptMay 25 2020, 7:01 AM

Harbormaster completed remote builds in B31285: Diff 72215.May 25 2020, 7:01 AM

lwhsu requested review of this revision.May 25 2020, 7:01 AM

Sure, looks good to me. I wonder whether 12.x already got it in base or not... So that the port could be made 11-only.

This revision is now accepted and ready to land.May 26 2020, 7:18 PM

Closed by commit rP537499: Fallback to uname(1) if freebsd-version(1) is not found (authored by lwhsu). · Explain WhyJun 1 2020, 6:23 PM

This revision was automatically updated to reflect the committed changes.

lwhsu added a commit: rP537499: Fallback to uname(1) if freebsd-version(1) is not found.

In D24994#550842, @tcberner wrote:

Sure, looks good to me. I wonder whether 12.x already got it in base or not... So that the port could be made 11-only.

/etc/os-release is not yet in 12.x so we still need this port. It has been marked IGNORE in 13.x

Revision Contents
Changeset List

Path

Size

head/

sysutils/

etc_os-release/

Makefile

6 lines

Diff 72541

View Options

head/sysutils/etc_os-release/Makefile

sysutils/etc_os-release: fallback to uname if freebsd-version not foundClosedPublicActions