Page MenuHomeFreeBSD

Update crypto(7) to list current ciphers.
Needs ReviewPublic

Authored by jhb on Fri, May 22, 5:29 PM.

Details

Reviewers
cem
Group Reviewers
manpages
Summary

Add descriptions of AES-CCM, Camellia-CBC, and Chacha20.

Test Plan

This doesn't try to resolve the issues of better names for stream
ciphers. OpenSSL seems to advertise an effective block size of 1
for stream ciphers (and AES-XTS) FWIW, so using a block size of 1
might not be the worst way to describe this.

I probably want to refactor this a bit further in the future to
split into separate sections for AEAD, "plain" cipher, and hashes.

Diff Detail

Repository
rS FreeBSD src repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 31240
Build 28889: arc lint + arc unit

Event Timeline

jhb created this revision.Fri, May 22, 5:29 PM
jhb requested review of this revision.Fri, May 22, 5:29 PM
jhb updated this revision to Diff 72128.Fri, May 22, 5:30 PM
  • crypto.ko still exists
cem added inline comments.Fri, May 22, 6:07 PM
share/man/man7/crypto.7
46–47

Doh, I misread this as changing the .It Dv rather than the width at first.

57

If we're documenting that counter-mode ciphers require IVs (nonces?), maybe document that CBC needs a random IV here.

71

I think "implements" fits better here than "uses."

The former sentence is already kind of awkward, so it might make sense to rewrite it to avoid "implements - implements" awkwardness too.

75

"read from or written to" is more English-ey. It reads more clearly to me in this instance.

79

"a unique nonce"?