Page MenuHomeFreeBSD

Zabbix 5.0 suite
Needs ReviewPublic

Authored by otis_sk.freebsd.org on Wed, May 20, 1:33 PM.

Details

Reviewers
mikael

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

otis_sk.freebsd.org requested review of this revision.Wed, May 20, 1:33 PM
mikael added inline comments.Wed, May 20, 2:00 PM
net-mgmt/zabbix5-agent2/Makefile
13

Does agent2 really require these options?

net-mgmt/zabbix5-server/Makefile
9

why is it commented?

34

You can merge the check: ${ZABBIX_BUILD:Nagent*}

70

ditto

121

${ZABBIX_BUILD:Magent*}
Do we need these options for agent2?

230

You can merge the 2 conditionnals.

otis_sk.freebsd.org planned changes to this revision.Wed, May 20, 9:41 PM
otis_sk.freebsd.org marked 5 inline comments as done.
otis_sk.freebsd.org added inline comments.
net-mgmt/zabbix5-agent2/Makefile
13

Yes.

net-mgmt/zabbix5-server/Makefile
9

This is only a remainder from previous run, left unnoticed.

otis_sk.freebsd.org marked 2 inline comments as done.

The build process still wants to fetch modules from the Internet. It has something to do with GOPATH, i suppose.

I have incorporated relevant parts of your work, fixed some glitches, tested on 11.3-RELEASE, 12-STABLE, 13-CURRENT. Builds on all three of them.

Fixed a problem where mock_server's pid file was not written thus mock_server could not be restarted.

There is still a lot of work needed for agent2 (it's mostly linux copy'n'paste)