Page MenuHomeFreeBSD

Move efi self-relocation code to boot/common.
ClosedPublic

Authored by ian on May 8 2015, 7:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 12:19 PM
Unknown Object (File)
Sun, Nov 17, 5:26 PM
Unknown Object (File)
Mon, Nov 11, 4:02 AM
Unknown Object (File)
Sun, Nov 3, 3:07 PM
Unknown Object (File)
Sun, Nov 3, 3:07 PM
Unknown Object (File)
Sun, Nov 3, 3:07 PM
Unknown Object (File)
Sun, Nov 3, 2:58 PM
Unknown Object (File)
Oct 25 2024, 11:19 PM
Subscribers

Details

Summary

The self-relocation code is not efi-specific, move it to boot/common.

The function was defined as taking 4 parameters and returning EFI_STATUS,
but all existing callers (in asm code) passed only two parameters and don't
use the return value. The function signature now matches that usage, and
doesn't refer to efi-specific types.

Parameters and variables now use the cannonical typenames set up by elf.h
(Elf_Word, Elf_Addr, etc) instead of raw C types. Hopefully this will
prevent suprises as new platforms come along and use this code.

The function was renamed from _reloc() to self_reloc() to emphasize its
difference from the other elf relocation code found in boot/common.

Test Plan

Passed make universe.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ian retitled this revision from to Move efi self-relocation code to boot/common..
ian updated this object.
ian edited the test plan for this revision. (Show Details)
ian added reviewers: rpaulo, emaste, andrew.
ian set the repository for this revision to rS FreeBSD src repository - subversion.

This is a prelude to making the armv6 ubldr self-relocating, which is working now but will be committed separately after this.

imp added a reviewer: imp.
This revision is now accepted and ready to land.May 8 2015, 7:56 PM
andrew edited edge metadata.
rpaulo edited edge metadata.
This revision was automatically updated to reflect the committed changes.