Assert that we are not descending through a leaf pointer.
ClosedPublic
Actions

Authored by markj on May 13 2020, 5:42 PM.

Details

Reviewers

alc
kib

Commits

rS361031: Assert that page table traversal functions don't operate on superpages.

Summary

This is useful for catching bugs. I will the change to other pmaps if
there are no objections to this.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj requested review of this revision.May 13 2020, 5:42 PM

markj created this revision.

Harbormaster completed remote builds in B31066: Diff 71728.May 13 2020, 5:42 PM

markj added reviewers: alc, kib.May 13 2020, 5:43 PM

D24652

This revision is now accepted and ready to land.May 13 2020, 6:04 PM

alc added inline comments.May 13 2020, 7:27 PM

sys/amd64/amd64/pmap.c
1346 ↗	(On Diff #71728)	"pdpe" -> "pde"

Fix a typo in the assertion string.

This revision now requires review to proceed.May 13 2020, 9:09 PM

Harbormaster completed remote builds in B31068: Diff 71736.May 13 2020, 9:09 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 14 2020, 3:49 PM

Closed by commit rS361031: Assert that page table traversal functions don't operate on superpages. (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS361031: Assert that page table traversal functions don't operate on superpages..

Herald added a subscriber: imp. · View Herald TranscriptMay 14 2020, 3:49 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

amd64/

pmap.c

4 lines

Diff 71779

View Options

head/sys/amd64/amd64/pmap.c

Assert that we are not descending through a leaf pointer.ClosedPublicActions