Page MenuHomeFreeBSD
Differential D24731

Add rib_lookup() sockaddr lookup wrapper and make ifa_ifwithroute use it.
ClosedPublic
Actions

Authored by melifaro on May 6 2020, 8:08 AM.
Tags
None
Referenced Files
F165255988: D24731.id71451.diff
Fri, Aug 7, 5:22 AM
Unknown Object (File)
Tue, Jul 28, 12:43 PM
Unknown Object (File)
Sun, Jul 26, 2:56 PM
Unknown Object (File)
Tue, Jul 21, 10:18 PM
Unknown Object (File)
Jul 7 2026, 2:28 PM
Unknown Object (File)
Jun 24 2026, 3:08 AM
Unknown Object (File)
Jun 18 2026, 3:27 AM
Unknown Object (File)
Jun 12 2026, 2:24 PM
View All Files
Subscribers
ae
imp

Details

Reviewers
None
Group Reviewers
network
Commits
rS360773: Add rib_lookup() sockaddr lookup wrapper and make ifa_ifwithroute use it.
Summary

Create rib_lookup() wrapper around per-af dataplane lookup functions.
This will help in the cases of having control plane af-agnostic code.

Switch ifa_ifwithroute() to use this function instead of rtalloc1().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

melifaro created this revision.May 6 2020, 8:08 AM
Herald added subscribers: ae, imp. · View Herald TranscriptMay 6 2020, 8:08 AM
melifaro requested review of this revision.May 6 2020, 8:08 AM
Harbormaster completed remote builds in B30944: Diff 71451.May 6 2020, 8:08 AM
ae added inline comments.May 6 2020, 9:07 AM
sys/net/route/route_helpers.c
113 ↗(On Diff #71451)

We usually don't use tab after #ifdef, only after #define.

116 ↗(On Diff #71451)

It seems & is not needed here.

124 ↗(On Diff #71451)

The same.

melifaro marked 3 inline comments as done.May 7 2020, 8:10 AM
This revision was not accepted when it landed; it landed in state Needs Review.May 7 2020, 8:12 AM
Closed by commit rS360773: Add rib_lookup() sockaddr lookup wrapper and make ifa_ifwithroute use it. (authored by melifaro). · Explain Why
This revision was automatically updated to reflect the committed changes.
melifaro added a commit: rS360773: Add rib_lookup() sockaddr lookup wrapper and make ifa_ifwithroute use it..

Revision Contents
Changeset List

PathSize
head/
sys/
net/
2 lines
32 lines
route/
51 lines

Diff 71493

View Options

head/sys/net/route.h

Loading...
View Options

head/sys/net/route.c

Loading...
View Options

head/sys/net/route/route_helpers.c

Loading...