sysutils/py-mqttwarn - update to Python 3

[dvl]

Summary

I can't find the 'binary' to install. I'm confused by the Python
cache directorie

[dvl]

Current status

[dvl]

I think I've solved this, since there is a pypi solution

[koobs]

sysutils/py-mqttwarn/Makefile

13–14

This can be dropped if it now supports versions other than 2.7

15–22

Can we collapse these lines into a single RUN_DEPENDS with \ line endings

25

Why does this need flavors?

sysutils/py-mqttwarn/files/patch-mqttwarn_core.py

9

Is this an upstream unreleased patch or something we have done only downstream?

Comment in patch header is useful for our future selves about what this is for, and what if anything needs to be done to upstream it (where possible)

[dvl]

Suggestions from koobs

[dvl]

Comment in patch to say why

[dvl]

sysutils/py-mqttwarn/Makefile

25

I cannot recall now. Removed.

sysutils/py-mqttwarn/files/patch-mqttwarn_core.py

9

Only downstream. I'll send it upstream.

[koobs]

sysutils/py-mqttwarn/files/patch-setup.py

13–16 ↗

(On Diff #75602)

These (all) == need to be replaced with >=. == dependencies are extremely brittle and break every time a port dependency version changes.

https://wiki.freebsd.org/Python/PortsPolicy#Dependencies

[dvl]

Updates based on comments

[dvl]

sysutils/py-mqttwarn/files/patch-setup.py

13–16 ↗

(On Diff #75602)

When I find: tests_require=extras['test'],

and that is defined as:

'test': [
    'pytest==4.6.7',
    'pytest-cov==2.8.1',
    'lovely.testlayers>=0.7.1',
    'tox==3.14.2',
],

Does this result:

TEST_DEPENDS= ${PYTHON_PKGNAMEPREFIX}pytest>0:devel/py-pytest \

${PYTHON_PKGNAMEPREFIX}pytest-cov>0:devel/py-pytest-cov \
${PYTHON_PKGNAMEPREFIX}tox>0:devel/py-tox

I could not locate lovely.testlayers in our tree.

13–16 ↗

(On Diff #75602)

Some of these values are modified from the upstream source (i.e. lower versions) because that is what we have in the ports tree now and I find that they work.

[dvl]

After talking with upstream (https://github.com/jpmens/mqttwarn/issues/441)
I've removed some patches as unrequired.

[dvl]

specify 3.6+ in USES= python
add concurrent to USE_PYTHON - port installs /usr/local/bin/mqttwarn
Add OPTIONS based on extras in setup.py

[koobs]

sysutils/py-mqttwarn/Makefile

24–25

Ports should 'declare' the versions that a package supports and not unnecessarily restrict/limit them.

The package support 2.7. USES=python is appropriate here.

24–25

cov (coverage) and (tox) are upstream development related test dependencies, and not necessary for downstream testing.

• Instead of depending on tox, depend on the thing that tox runs. In this case, only pytest [1]
• To remove/override non-compulsory upstream development test dependencies, invoke pytest directly in the do-test target:

do-test:
		@cd ${WRKSRC} && ${PYTHON_CMD} -m pytest -v -rs -o addopts=

-o addopts= overrides test settings/arguments set in pytest.ini or setup.cfg:[pytest] sections (which adds --cov, requiring pytest-cov)

Upstream should move these 'non-compulsory' test dependencies to an extras_require[dev] section, that tox.ini then pulls in. This will leave extras_require[test] as purely compulsory test dependencies (pytest, and optional run time deps)

[1] https://github.com/jpmens/mqttwarn/blob/master/tox.ini#L8

42–44

All of these extras_require (optional deps) need to be switched from == to >= too.

Note: this does not guarantee that upstream tests with them, or that they will work.

Upstream needs to change their pinned (==) deps to >= (for sdist/setup.py/users) so that they are testing future versions of their dependencies before users get them. This also avoids conflicts between package versions downstream as well.

If they want to continue to pin versions, this can be done in requirements.txt files (unrelated to distribution), but this is not recommended either.

[koobs]

sysutils/py-mqttwarn/files/patch-setup.py

13–16 ↗

(On Diff #75602)

I usually just add # <test dependency line> # to be ported until its ported

[dvl]

Don't be so specific with python
change test deps
change do-test

[dvl]

thanks

[koobs]

sysutils/py-mqttwarn/Makefile

13–14

RUN_DEPENDS <version-specs> should always match those in setup.py as closely as possible:

+    'six>=1.13.0',
+    'paho-mqtt>=1.4.0',
+    'jinja2>=2.10.1',
+    'attrs>=19.3.0',
+    'docopt>=0.6.2',
+    'requests>=2.22.0',
+    'future>=0.18.2',
+    'configparser>=3.5.3',

48

is this all that's required? There's no Python mysql package required to wrap mysqlclient.so ?

[dvl]

Adjust RUN_DEPENDS to match setup.py patches

[dvl]

Add version for rrdtool

[koobs]

Looks good Dan!