sysutils/bsdstats: Update to 7.0

[salvadore]

Summary

• Use pkg query %n:%v:%o instead of pkg info -o “*” to get list of installed packages. This simplifies processing and accuracy of split for version numbers on the report server by not having to guess where that split is.
• Check for existence of /usr/local/etc/bsdstats.conf and if it exists, restrict ports submitted to those listed in there.
• Add a note to pkg-message.in about /usr/local/etc/bsdstats.conf
• Get rid of the LIMITED config option: LIMITED is enabled if and only if /usr/local/etc/bsdstats.conf exists.

While here, also modernize port using option helpers.

Submitted by: scrappy

[salvadore]

I propose a verbose commit message (based on scrappy's own draft) because the software is developped in the port itself, so a bit more details about the development might be useful in the future.

[gerald]

Looks okay to me, and the longer commit message definitely is a good idea.

One minor note: "While here, also modernize port using option helpers." lacks a "the" or "this" as in "this port".

And should /usr/local be $PREFIX?

[salvadore]

Committed taking into account your comments.

Unfortunately I missed an occurence of /usr/local in pkg-message, so I had to make one more commit (I considered it as already approved from you since it is a forgotten part of this one): https://svnweb.freebsd.org/ports?view=revision&revision=533480

[gerald]

In D24644#542490, @salvadore wrote:

Committed taking into account your comments.

Thanks!

Unfortunately I missed an occurence of /usr/local in pkg-message, so I had to make one more commit (I considered it as already approved from you since it is a forgotten part of this one):

Yes, of course. No worries (and no delays in improving/fixing such things while you wait for me to get up/in front of a computer/...).