www/osrm-backend: Fix build on CURRENT and pet portlint
ClosedPublic
Actions

Authored by lbartoletti on Apr 29 2020, 7:20 PM.

Details

Reviewers

tcberner
swills

Commits

rP535738: www/osrm-backend: Fix build on CURRENT and pet portlint

Summary

Fix build on CURRENT and pet portlint

Submitted by maintainer

Test Plan

porlint (looks fine.)
poudriere (11/12/HEAD i386/amd64)

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lbartoletti created this revision.Apr 29 2020, 7:20 PM

Herald added a subscriber: mat. · View Herald TranscriptApr 29 2020, 7:20 PM

lbartoletti requested review of this revision.Apr 29 2020, 7:20 PM

Harbormaster completed remote builds in B30799: Diff 71162.Apr 29 2020, 7:20 PM

I see why there are so many whitespace changes... but :D

www/osrm-backend/Makefile
41 ↗	(On Diff #71162)	why `bsd.port.options.mk` and not `bsd.ports.pre.mk`? [1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-after-port-mk.html

lbartoletti marked an inline comment as done.Apr 30 2020, 1:27 PM

lbartoletti added inline comments.

www/osrm-backend/Makefile
41 ↗	(On Diff #71162)	My bad, I pushed his patch and not the fixed one

Use bsd.ports.pre.mk instead of bsd.port.options.mk

Harbormaster completed remote builds in B30808: Diff 71183.Apr 30 2020, 1:35 PM

Can I ship it?

stlgtm

This revision is now accepted and ready to land.May 17 2020, 7:23 PM

Closed by commit rP535738: www/osrm-backend: Fix build on CURRENT and pet portlint (authored by lbartoletti). · Explain WhyMay 18 2020, 1:38 PM

This revision was automatically updated to reflect the committed changes.

lbartoletti added a commit: rP535738: www/osrm-backend: Fix build on CURRENT and pet portlint.

Revision Contents
Changeset List

Path

Size

head/

www/

osrm-backend/

Makefile

65 lines

Diff 71921

View Options

head/www/osrm-backend/Makefile

www/osrm-backend: Fix build on CURRENT and pet portlintClosedPublicActions