Page MenuHomeFreeBSD

liblua: ensure that "require" will fail in bootstrap flua
ClosedPublic

Authored by emaste on Apr 28 2020, 11:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 10, 9:59 PM
Unknown Object (File)
Sun, Sep 6, 3:41 PM
Unknown Object (File)
Sat, Sep 5, 4:13 PM
Unknown Object (File)
Sat, Sep 5, 2:06 PM
Unknown Object (File)
Fri, Sep 4, 11:23 PM
Unknown Object (File)
Fri, Sep 4, 6:12 AM
Unknown Object (File)
Wed, Sep 2, 8:11 PM
Unknown Object (File)
Wed, Sep 2, 5:49 PM
Subscribers
None

Details

Summary

We do not want to support bootstrapping lua modules, so ensure that require will fail by providing a nonexistent path.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.
kevans added inline comments.
lib/liblua/Makefile
31 โ†—(On Diff #71133)

This should probably read ?.so to be consistent with the name, but given that we're intentionally clobbering these to something that won't resolve, I won't insist.

This revision is now accepted and ready to land.Apr 29 2020, 12:59 AM
lib/liblua/Makefile
31 โ†—(On Diff #71133)

Yes good point, I just cut and pasted.

We could actually drop the ? part completely, just /nonexistent and it would fail just as well, but the ? may give a necessary clue via dtrace/ktrace if bootstrap does break from this.