flua: support "require" in the base system
ClosedPublic
Actions

Authored by emaste on Apr 28 2020, 5:29 PM.

Details

Reviewers

Commits

rS364182: flua: initial support for "require" in the base system

Summary

Use /usr not /usr/local for base system components. Use /usr/lib/flua and /usr/share/flua (not lua) for consistency and to avoid other software accidentally finding our modules.

Also drop the version from the path, as flua represents an unspecified lua version that corresponds to the FreeBSD version it comes with.

Enable dlopen.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Apr 28 2020, 5:29 PM

emaste created this revision.

Posted initially for discussion, not a final committable change.

That said we could start using .lua modules in /usr/share/flua.

lib/liblua/luaconf.h
78 ↗	(On Diff #71117)	This does not yet work (without changes to add some flua symbols to dynamic sym list).

kevans added inline comments.Apr 28 2020, 5:40 PM

lib/liblua/luaconf.h
211 ↗	(On Diff #71117)	Yup, this is exactly what I had in mind -- we might consider only defining LUA_ROOT if it's not defined, so we have the possibility of defining it to somewhere /nonexistent (or somewhere valid) in the BOOTSTRAPPING build to make sure the bootstrap flua can't pick up host modules that may not match the flua being built.

emaste added a subscriber: imp.Apr 28 2020, 8:42 PM

emaste added inline comments.

lib/liblua/luaconf.h
211 ↗	(On Diff #71117)	What's your opinion on dropping the version?

kevans added inline comments.Apr 28 2020, 11:23 PM

lib/liblua/luaconf.h
211 ↗	(On Diff #71117)	Dropping the version does seem like a good idea... nothing should need to know/care as stuff installed here should be pretty tightly coupled to flua in some way, and it does reinforce the (lack of) stability guarantees, I think.