Build libgomp only if we're also building base system GCC
ClosedPublic
Actions

Authored by emaste on May 6 2015, 12:46 AM.

Details

Reviewers

davide
pfg
adrian

Commits

rS282973: Build libgomp only if we're also building base system GCC

Summary

Clang's OpenMP support will emit Intel OpenMP API library calls, and will therefore require libiomp (or whatever name is settled on). An up-to-date version of libgomp is included in ports or pkg GCC. Thus, there is no reason to build base libgomp without base system GCC.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 5220.May 6 2015, 12:46 AM

emaste retitled this revision from to Build libgomp only if we're also building base system GCC.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: pfg, adrian, davide.

Yes, libgomp is part of gcc anyways.

This revision is now accepted and ready to land.May 6 2015, 12:52 AM

Related PR pointed out by @pfg - https://bugs.freebsd.org/199897

exp-run requested here, for completeness:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199979

One port (octave-forge-nurbs) failed with this change, because it unconditionally relies on omp.h. I'm waiting on feedback from the maintainer before committing.

Closed by commit rS282973: Build libgomp only if we're also building base system GCC (authored by emaste). · Explain WhyMay 15 2015, 2:22 PM

This revision was automatically updated to reflect the committed changes.