Don't run strcmp() against strings stored in user memory.
ClosedPublic
Actions

Authored by jhb on Apr 24 2020, 11:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jul 27, 5:27 PM

	Unknown Object (File)
	Sun, Jul 19, 11:10 PM

	Unknown Object (File)
	Fri, Jul 17, 7:31 AM

	Unknown Object (File)
	Sat, Jul 11, 11:59 AM

	Unknown Object (File)
	Jul 4 2026, 12:14 PM

	Unknown Object (File)
	Jul 3 2026, 7:28 AM

	Unknown Object (File)
	Jul 3 2026, 5:54 AM

	Unknown Object (File)
	Jun 30 2026, 10:07 PM

View All Files

Subscribers

imp

Details

Reviewers

brooks
kib

Commits

rS360388: Don't run strcmp() against strings stored in user memory.

Summary

Instead, copy the strings into a temporary buffer on the stack and
run strcmp on the copies.

Test Plan

compile tested only

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Apr 24 2020, 11:50 PM

Harbormaster completed remote builds in B30716: Diff 70971.Apr 24 2020, 11:50 PM

kib accepted this revision.Apr 25 2020, 12:39 PM

This revision is now accepted and ready to land.Apr 25 2020, 12:39 PM

brooks accepted this revision.Apr 27 2020, 5:18 PM

Closed by commit rS360388: Don't run strcmp() against strings stored in user memory. (authored by jhb). · Explain WhyApr 27 2020, 6:04 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS360388: Don't run strcmp() against strings stored in user memory..

Herald added a subscriber: imp. · View Herald TranscriptApr 27 2020, 6:04 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

iscsi_initiator/

isc_subr.c

17 lines

Diff 71071

View Options

head/sys/dev/iscsi_initiator/isc_subr.c

Don't run strcmp() against strings stored in user memory.ClosedPublicActions