Page MenuHomeFreeBSD

hdac: replace sketchy printf for unowned lock with a lock assertion
ClosedPublic

Authored by emaste on Apr 18 2020, 12:47 AM.
Tags
None
Referenced Files
F133616766: D24479.id.diff
Mon, Oct 27, 1:26 AM
F133616753: D24479.id70722.diff
Mon, Oct 27, 1:26 AM
F133616749: D24479.id70721.diff
Mon, Oct 27, 1:26 AM
F133583720: D24479.diff
Sun, Oct 26, 7:59 PM
Unknown Object (File)
Sat, Oct 18, 2:14 AM
Unknown Object (File)
Sep 20 2025, 10:33 PM
Unknown Object (File)
Sep 19 2025, 4:41 AM
Unknown Object (File)
Aug 24 2025, 7:56 AM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

hdac_send_command is called from one place that takes the lock and from

static uint32_t
hdac_codec_command(device_t dev, device_t child, uint32_t verb)
{

        return (hdac_send_command(device_get_softc(dev),
            (intptr_t)device_get_ivars(child), verb));
}

        DEVMETHOD(hdac_codec_command,   hdac_codec_command),

hdac.h

#define hda_command(dev, verb)                                  \
    HDAC_CODEC_COMMAND(device_get_parent(dev), (dev), (verb))
This revision is now accepted and ready to land.Apr 18 2020, 12:52 AM

This seems to be a very old piece of code. :)

This seems to be a very old piece of code. :)

Indeed :)

I knew next to nothing about snd_hda last week; I'm reading through it to understand how it works and finding little nits like this along the way.