Page MenuHomeFreeBSD

hdac: replace sketchy printf for unowned lock with a lock assertion
ClosedPublic

Authored by emaste on Apr 18 2020, 12:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 27, 3:09 PM
Unknown Object (File)
Nov 1 2024, 9:30 PM
Unknown Object (File)
Sep 29 2024, 3:01 PM
Unknown Object (File)
Sep 28 2024, 5:51 PM
Unknown Object (File)
Sep 28 2024, 5:51 PM
Unknown Object (File)
Sep 28 2024, 5:51 PM
Unknown Object (File)
Sep 28 2024, 5:38 PM
Unknown Object (File)
Sep 14 2024, 1:11 AM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

hdac_send_command is called from one place that takes the lock and from

static uint32_t
hdac_codec_command(device_t dev, device_t child, uint32_t verb)
{

        return (hdac_send_command(device_get_softc(dev),
            (intptr_t)device_get_ivars(child), verb));
}

        DEVMETHOD(hdac_codec_command,   hdac_codec_command),

hdac.h

#define hda_command(dev, verb)                                  \
    HDAC_CODEC_COMMAND(device_get_parent(dev), (dev), (verb))
This revision is now accepted and ready to land.Apr 18 2020, 12:52 AM

This seems to be a very old piece of code. :)

This seems to be a very old piece of code. :)

Indeed :)

I knew next to nothing about snd_hda last week; I'm reading through it to understand how it works and finding little nits like this along the way.