Abort transfer if fseeko() fails.
ClosedPublic
Actions

Authored by jhb on Apr 16 2020, 10:10 PM.

Details

Reviewers

asomers

Commits

rS360167: Abort transfer if fseeko() fails.

Summary

CID: 1420215

Test Plan

did some simple transfers with windowsize of 1 and 16

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30546
Build 28292: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 16 2020, 10:10 PM

Harbormaster completed remote builds in B30546: Diff 70665.Apr 16 2020, 10:10 PM

Hm. How did you discover this problem? Did you try to read an unseekable file or something? And have you run the unit tests with this change?

I have not seen this, this is based on the coverity report that you forwarded me a while back. I didn't run the tests at first as I didn't think they would really cover this well, but they do at least cover that normal transfers still work, so I ran them and they passed.

For consistency, shouldn't you also tftp_log(LOG_ERR, ...)?