Page MenuHomeFreeBSD

Remove "capability mode sandbox enabled" messages.
ClosedPublic

Authored by brooks on May 4 2015, 3:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 6:39 AM
Unknown Object (File)
Fri, Apr 26, 6:22 AM
Unknown Object (File)
Mar 10 2024, 12:36 PM
Unknown Object (File)
Mar 10 2024, 12:33 PM
Unknown Object (File)
Mar 10 2024, 12:33 PM
Unknown Object (File)
Mar 7 2024, 7:24 PM
Unknown Object (File)
Jan 9 2024, 8:03 AM
Unknown Object (File)
Jan 3 2024, 11:42 AM
Subscribers

Details

Summary

These messages serve little purpose and break some scripts:

PR: 199855
Sponsored by: DARPA, AFRL

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks retitled this revision from to Remove "capability mode sandbox enabled" messages..
brooks updated this object.
brooks edited the test plan for this revision. (Show Details)
brooks added reviewers: pjd, rwatson.

I'll submit the tcpdump change upstream after this goes in.

rwatson edited edge metadata.

Seems reasonable to me. I'd rather take sandboxing for granted and not have output. An interesting question, of course, is whether we want a more mature policy than "Is Capsicum compiled into the kernel?" to control whether to fail stop if sandboxing fails. My intuition is that the status quo is fine there -- i.e., that if Capsicum is present we expect to be in a sandbox, and if not, we don't. You could imagine some sort of assert_cap_sandboxed() but I'm also not convinced that adds anything over the current check on the cap_enter() return value.

This revision is now accepted and ready to land.May 4 2015, 4:08 PM
This revision was automatically updated to reflect the committed changes.