Page MenuHomeFreeBSD

lang/go-devel: Convert to slave of lang/go, apply D24122
ClosedPublic

Authored by dmgk on Apr 13 2020, 3:13 PM.

Details

Summary
- Convert to slave port of lang/go
- Apply D24122 (similar to r530387 for lang/go) to relax module consistency
  checks in go1.14 mode
Test Plan

poudriere testport: OK for both lang/go and lang/go-devel

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dmgk created this revision.Apr 13 2020, 3:13 PM
tobik added inline comments.Apr 13 2020, 3:56 PM
lang/go/Makefile
39–40 ↗(On Diff #70494)

Unrelated to this review, but these are now flagged by portscan/portclippy. Can you drop them? Without setting SHEBANG_LANG=sh they are unused.

42 ↗(On Diff #70494)

Overwrites the one from go-devel. Use ?=.

dmgk updated this revision to Diff 70500.Apr 13 2020, 4:14 PM
dmgk marked 2 inline comments as done.
  • remove sh*CMD
  • do not overwrite CONFLICTS_INSTALL
tobik accepted this revision.Apr 13 2020, 4:19 PM

Thanks. One more nit but otherwise LGTM.

lang/go/Makefile
16 ↗(On Diff #70500)

Oh, COMMENT also needs ?=.

This revision is now accepted and ready to land.Apr 13 2020, 4:19 PM
dmgk updated this revision to Diff 70502.Apr 13 2020, 4:28 PM
  • also leave COMMENT alone
This revision now requires review to proceed.Apr 13 2020, 4:28 PM
dmgk marked an inline comment as done.Apr 13 2020, 4:29 PM
dmgk added inline comments.
lang/go/Makefile
16 ↗(On Diff #70500)

Thanks for catching these.

dmgk marked an inline comment as done.Apr 13 2020, 4:31 PM
mikael accepted this revision.Apr 13 2020, 6:53 PM
This revision is now accepted and ready to land.Apr 13 2020, 6:53 PM
This revision was automatically updated to reflect the committed changes.