Page MenuHomeFreeBSD

Patch to support Amlogic uart lower speeds
ClosedPublic

Authored by john-feith.com on May 3 2015, 3:19 AM.
Tags
Referenced Files
Unknown Object (File)
Tue, Dec 17, 9:50 PM
Unknown Object (File)
Thu, Dec 12, 1:29 AM
Unknown Object (File)
Mon, Dec 9, 8:38 PM
Unknown Object (File)
Sun, Dec 8, 6:41 AM
Unknown Object (File)
Tue, Nov 26, 2:27 AM
Unknown Object (File)
Nov 12 2024, 7:24 AM
Unknown Object (File)
Nov 12 2024, 3:28 AM
Unknown Object (File)
Nov 1 2024, 2:32 PM
Subscribers

Details

Reviewers
ganbold
Summary

This patch adds support for the extended baud rate register
available on the aml8726-m6 (and later) SoC which allows for
lower speeds.

Test Plan

Smoke tested on the ODROID-C1 at 110, 150, 300, 600, 1200,
38400, and 115200 baud.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

john-feith.com retitled this revision from to Patch to support Amlogic uart lower speeds.
john-feith.com updated this object.
john-feith.com edited the test plan for this revision. (Show Details)
john-feith.com added a reviewer: ganbold.
john-feith.com set the repository for this revision to rS FreeBSD src repository - subversion.
john-feith.com added a project: ARM.

Other than style in one place it seems ok.

sys/arm/amlogic/aml8726/uart_dev_aml8726.c
158

I'm not good at style(9), but I'd get one tab (4 spaces) from if column. Actually style(9) recommends:
...
Indentation is an 8 character tab. Second level indents are four spaces.
...

john-feith.com edited edge metadata.

I've reformatted the line in question.

ganbold edited edge metadata.
This revision is now accepted and ready to land.May 6 2015, 1:18 AM