Page MenuHomeFreeBSD

Allow the kernel to build with a compiler that sets -fno-common.
ClosedPublic

Authored by brooks on Apr 6 2020, 10:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 2, 8:29 PM
Unknown Object (File)
Fri, May 1, 11:27 AM
Unknown Object (File)
Wed, Apr 29, 1:39 AM
Unknown Object (File)
Wed, Apr 29, 1:32 AM
Unknown Object (File)
Mon, Apr 27, 10:02 PM
Unknown Object (File)
Sat, Apr 25, 4:30 AM
Unknown Object (File)
Wed, Apr 15, 8:14 PM
Unknown Object (File)
Wed, Apr 15, 5:25 AM
Subscribers
None

Details

Summary

The mechanism that generates assym.inc and offset.inc depends on the
symbols in question being common. For now, simply force the object files
to be created with -fcommon.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I took a brief look at rewriting the awk to work with either -fcommon or -fno-common a lttle bit ago, but that's non-trivial as things don't line up as neatly.

This revision is now accepted and ready to land.Apr 6 2020, 10:38 PM

The values are also quite different if you diff the nm output. I think this whole thing will need to be rethought eventually, but removing -fcommon is probably a long ways off.