www/nift: Update to 2.2
ClosedPublic
Actions

Authored by lbartoletti on Apr 5 2020, 6:10 AM.

Details

Reviewers

tcberner
swills

Commits

rP530832: www/nift: Update to 2.2

Summary

Update to 2.2

Test Plan

Portlint (looks fine.)
Poudriere (11/12/HEAD i386/amd64)

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lbartoletti created this revision.Apr 5 2020, 6:10 AM

Herald added a subscriber: mat. · View Herald TranscriptApr 5 2020, 6:10 AM

Harbormaster completed remote builds in B30294: Diff 70219.Apr 5 2020, 6:10 AM

Looks good to me

This revision is now accepted and ready to land.Apr 5 2020, 6:45 AM

Use %%LOCALBASE%% instead of hardcoded /usr/local

This revision now requires review to proceed.Apr 5 2020, 7:26 AM

Harbormaster completed remote builds in B30295: Diff 70221.Apr 5 2020, 7:26 AM

tcberner added inline comments.Apr 5 2020, 8:08 AM

www/nift/files/patch-Makefile
9 ↗	(On Diff #70221)	^the first / seems not necessary. but good catch :)

but, why not simply use USES=localbase, which already adds -L/-I to ${LOCALBASE} -- then that hunk could be dropped completely, no?

In D24298#534503, @tcberner wrote:

but, why not simply use USES=localbase, which already adds -L/-I to ${LOCALBASE} -- then that hunk could be dropped completely, no?

I tried too, but nift Makefile doesn't seems to take care about our flags (even patching Makefile to replace LINK by LDFLAGS and add USES localbase:ldflags)

Remove the first path separator not required

Harbormaster completed remote builds in B30297: Diff 70225.Apr 5 2020, 10:06 AM

lbartoletti marked an inline comment as done.Apr 5 2020, 10:06 AM

Looks good to me.

This revision is now accepted and ready to land.Apr 5 2020, 5:02 PM

Closed by commit rP530832: www/nift: Update to 2.2 (authored by lbartoletti). · Explain WhyApr 5 2020, 8:12 PM

This revision was automatically updated to reflect the committed changes.

lbartoletti added a commit: rP530832: www/nift: Update to 2.2.