While touching these files also add lots of static to fix the build without
settings WARNS to 2.
Details
Details
- Reviewers
kevans - Commits
- rS360073: Fix various warnings in tests/sys/kqueue and bump WARNS
compiles
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Crap, sorry, I already committed part of this because I forgot this review hit my inbox. =(
kqfd is actually meant to be shared throughout libkqueue at the moment -- note, e.g., test_no_kevents that's checking a kqfd and being called from other CUs. I removed all of the other kqfd declarations, so this will hit some kind of tedious merge conflicts when applied... the rest of the patch LGTM, so if you'd like I can rebase it forward and commit the WARNS fixes if you'd rather not deal with the mess I've left.
Comment Actions
You're right, I just fixed the warning without seeing that it's meant to be shared. I'll rebase the warning fixes on top of you changes. Should be trivial.