Page MenuHomeFreeBSD

Fix tests/sys/kqueue without -fcommon and bump WARNS
ClosedPublic

Authored by arichardson on Apr 4 2020, 12:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 2, 9:49 AM
Unknown Object (File)
May 8 2024, 8:15 PM
Unknown Object (File)
May 8 2024, 8:14 PM
Unknown Object (File)
May 7 2024, 1:52 AM
Unknown Object (File)
Apr 3 2024, 11:57 AM
Unknown Object (File)
Mar 19 2024, 7:40 PM
Unknown Object (File)
Feb 3 2024, 11:01 AM
Unknown Object (File)
Dec 29 2023, 2:24 PM
Subscribers

Details

Summary

While touching these files also add lots of static to fix the build without
settings WARNS to 2.

Test Plan

compiles

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fix two more warnings that I missed

Crap, sorry, I already committed part of this because I forgot this review hit my inbox. =(

kqfd is actually meant to be shared throughout libkqueue at the moment -- note, e.g., test_no_kevents that's checking a kqfd and being called from other CUs. I removed all of the other kqfd declarations, so this will hit some kind of tedious merge conflicts when applied... the rest of the patch LGTM, so if you'd like I can rebase it forward and commit the WARNS fixes if you'd rather not deal with the mess I've left.

Crap, sorry, I already committed part of this because I forgot this review hit my inbox. =(

kqfd is actually meant to be shared throughout libkqueue at the moment -- note, e.g., test_no_kevents that's checking a kqfd and being called from other CUs. I removed all of the other kqfd declarations, so this will hit some kind of tedious merge conflicts when applied... the rest of the patch LGTM, so if you'd like I can rebase it forward and commit the WARNS fixes if you'd rather not deal with the mess I've left.

You're right, I just fixed the warning without seeing that it's meant to be shared. I'll rebase the warning fixes on top of you changes. Should be trivial.

This revision is now accepted and ready to land.Apr 9 2020, 3:44 PM