Page MenuHomeFreeBSD
Differential D24230

Relax existence check of ${LOCALBASE}/bin/kyua in Makefile.inc1
ClosedPublic
Actions

Authored by driesm on Mar 30 2020, 7:47 PM.
Tags
None
Referenced Files
F86816958: D24230.diff
Wed, Jun 26, 12:52 AM
F86815487: D24230.id.diff
Wed, Jun 26, 12:23 AM
Unknown Object (File)
Tue, Jun 25, 3:34 AM
Unknown Object (File)
Mon, Jun 24, 8:30 PM
Unknown Object (File)
Mon, Jun 24, 1:25 PM
Unknown Object (File)
Sat, Jun 22, 8:20 PM
Unknown Object (File)
Sat, Jun 22, 4:01 PM
Unknown Object (File)
Fri, Jun 21, 12:57 AM
View All 24 Files
Subscribers
emaste
imp

Details

Reviewers
brooks
Commits
rS359456: Relax existence check of ${LOCALBASE}/bin/kyua
Summary

After the base kyua import the testsuite can utilize the in-base kyua just fine.

Test Plan

make checkworld with:

  • In base kyua not present, port installed => Runs fine
  • In base kyua present, port not installed => Runs fine
  • In base kyua not present, port not installed => Fails

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

driesm created this revision.Mar 30 2020, 7:47 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptMar 30 2020, 7:47 PM
brooks accepted this revision.Mar 30 2020, 8:02 PM

LGTM. I'll commit shortly.

This revision is now accepted and ready to land.Mar 30 2020, 8:02 PM
Closed by commit rS359456: Relax existence check of ${LOCALBASE}/bin/kyua (authored by brooks). · Explain WhyMar 30 2020, 8:05 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rS359456: Relax existence check of ${LOCALBASE}/bin/kyua.

Revision Contents
Changeset List

PathSize
head/
2 lines

Diff 70020

View Options

head/Makefile.inc1

Loading...