Page MenuHomeFreeBSD

Fix parameter reversal potentially causing buffer overrun.
ClosedPublic

Authored by dab on Wed, Mar 18, 6:14 PM.

Details

Summary

Two arguments were reversed in calls to cam_strvis() in
nvme_da.c. This was found by a Coverity scan of this code within
Dell (Isilon). These are also marked in the FreeBSD Coverity scan
as CIDs 1400526 & 1400531.

Test Plan

Code inspection

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dab created this revision.Wed, Mar 18, 6:14 PM
vangyzen accepted this revision.Wed, Mar 18, 6:25 PM

Wow, that API is unfortunate.

This revision is now accepted and ready to land.Wed, Mar 18, 6:25 PM
imp accepted this revision.Wed, Mar 18, 6:29 PM
dab added a comment.Wed, Mar 18, 9:08 PM

Wow, that API is unfortunate.

No kidding.

This revision was automatically updated to reflect the committed changes.