lang/rust: Update to 1.42.0

[tobik]

Summary

Scheduled to be released on 2020-03-12.

https://internals.rust-lang.org/t/rust-1-42-0-pre-release-testing/11949
https://github.com/rust-lang/rust/blob/stable/RELEASES.md#version-1420-2020-03-12

Test Plan

11.3 amd64 ok
11.3 i386 ok, consumers ok
12.1 amd64 ok, consumers ok
12.1 i386 ok
13.0 amd64 ok
13.0 i386 ok

arm64 ?
armv6 ok
armv7 ok
ppc64 elfv1 ok
ppc64 elfv2 ok

[mikael]

I have 2 errors with lang/rust-bootstrap:

error: unnecessary parentheses around block return value
    --> src/bootstrap/lib.rs:1029:9
     |
1029 |         (target.contains("linux-gnu") || target.contains("apple-darwin"))
     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
     |
     = note: `-D unused-parens` implied by `-D warnings`


error: unused extern crate
 --> src/librustc_macros/src/lib.rs:4:1
  |
4 | extern crate proc_macro;
  | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove it
  |
  = note: `-D unused-extern-crates` implied by `-D warnings`

[tobik]

• Attempt to unbreak rust-bootstrap by turning off deny-warnings

[mikael]

In D24020#528288, @tobik wrote:

• Attempt to unbreak rust-bootstrap by turning off deny-warnings

That fixed the issue, thanks.

[mikael]

OK on 13amd64, 13i386, armv7 and ppc64 elfv2. I'll have the result for other arches tomorrow.

edit: ok on armv6 and ppc64 elfv1
I have a problem on aarch64:

command did not execute successfully: "/usr/ports/lang/rust/work/rustc-1.42.0-src/build/aarch64-unknown-freebsd/stage0/bin/cargo" "build" "-Zconfig-profile" "--target" "aarch64-unknown-freebsd" "-Zbinary-dep-de
pinfo" "-j" "4" "-v" "--release" "--frozen" "--manifest-path" "/usr/ports/lang/rust/work/rustc-1.42.0-src/src/tools/miri/Cargo.toml" "--message-format" "json-render-diagnostics"
expected success, got: signal: 11
      < ToolBuild { compiler: Compiler { stage: 2, host: "aarch64-unknown-freebsd" }, target: "aarch64-unknown-freebsd", tool: "cargo-miri", path: "src/tools/miri", mode: ToolRustc, is_optional_tool: true, sour
ce_type: Submodule, extra_features: [] }
    < CargoMiri { compiler: Compiler { stage: 2, host: "aarch64-unknown-freebsd" }, target: "aarch64-unknown-freebsd", extra_features: [] }
thread 'main' panicked at 'Unable to build cargo miri', src/bootstrap/dist.rs:65:9

[tobik]

In D24020#528377, @mikael wrote:

I have a problem on aarch64:

command did not execute successfully: "/usr/ports/lang/rust/work/rustc-1.42.0-src/build/aarch64-unknown-freebsd/stage0/bin/cargo" "build" "-Zconfig-profile" "--target" "aarch64-unknown-freebsd" "-Zbinary-dep-de
pinfo" "-j" "4" "-v" "--release" "--frozen" "--manifest-path" "/usr/ports/lang/rust/work/rustc-1.42.0-src/src/tools/miri/Cargo.toml" "--message-format" "json-render-diagnostics"
expected success, got: signal: 11
      < ToolBuild { compiler: Compiler { stage: 2, host: "aarch64-unknown-freebsd" }, target: "aarch64-unknown-freebsd", tool: "cargo-miri", path: "src/tools/miri", mode: ToolRustc, is_optional_tool: true, sour
ce_type: Submodule, extra_features: [] }
    < CargoMiri { compiler: Compiler { stage: 2, host: "aarch64-unknown-freebsd" }, target: "aarch64-unknown-freebsd", extra_features: [] }
thread 'main' panicked at 'Unable to build cargo miri', src/bootstrap/dist.rs:65:9

Do you have a full log?

[mikael]

In D24020#528541, @tobik wrote:

In D24020#528377, @mikael wrote:

I have a problem on aarch64:

command did not execute successfully: "/usr/ports/lang/rust/work/rustc-1.42.0-src/build/aarch64-unknown-freebsd/stage0/bin/cargo" "build" "-Zconfig-profile" "--target" "aarch64-unknown-freebsd" "-Zbinary-dep-de
pinfo" "-j" "4" "-v" "--release" "--frozen" "--manifest-path" "/usr/ports/lang/rust/work/rustc-1.42.0-src/src/tools/miri/Cargo.toml" "--message-format" "json-render-diagnostics"
expected success, got: signal: 11
      < ToolBuild { compiler: Compiler { stage: 2, host: "aarch64-unknown-freebsd" }, target: "aarch64-unknown-freebsd", tool: "cargo-miri", path: "src/tools/miri", mode: ToolRustc, is_optional_tool: true, sour
ce_type: Submodule, extra_features: [] }
    < CargoMiri { compiler: Compiler { stage: 2, host: "aarch64-unknown-freebsd" }, target: "aarch64-unknown-freebsd", extra_features: [] }
thread 'main' panicked at 'Unable to build cargo miri', src/bootstrap/dist.rs:65:9

Do you have a full log?

No, it's probably a problem on my board. I'm rebuilding it.

[mikael]

It's ok on aarch64

head/Mk/Uses/cargo.mk

vfs_donmount(struct thread *td, uint64_t fsflags, struct uio *fsoptions)
          * If has_nonexport is true or the caller is not running within a
          * vnet prison that can run mountd(8), set jail_export false.
          */
         if (has_nonexport || !jailed(td->td_ucred) ||
             !prison_check_nfsd(td->td_ucred))
                 jail_export = false;
 
         error = vfs_domount(td, fstype, fspath, fsflags, jail_export, &optlist);
-        if (error == ENOENT) {
+        if (error == ENODEV) {
                 error = EINVAL;
                 if (errmsg != NULL)
                         strncpy(errmsg, "Invalid fstype", errmsg_len);
                 goto bail;
         }
 
         /*
          * See if we can mount in the read-only mode if the error code suggests
if (error) {
                 free(fstype, M_TEMP);
                 return (error);
         }
 
         AUDIT_ARG_TEXT(fstype);
         vfsp = vfs_byname_kld(fstype, td, &error);
         free(fstype, M_TEMP);
         if (vfsp == NULL)
-                return (ENOENT);
+                return (EINVAL);
         if (((vfsp->vfc_flags & VFCF_SBDRY) != 0 &&
             vfsp->vfc_vfsops_sd->vfs_cmount == NULL) ||
             ((vfsp->vfc_flags & VFCF_SBDRY) == 0 &&
             vfsp->vfc_vfsops->vfs_cmount == NULL))
                 return (EOPNOTSUPP);
 
         ma = mount_argsu(ma, "fstype", uap->type, MFSNAMELEN);
         ma = mount_argsu(ma, "fspath", uap->path, MNAMELEN);

head/audio/ncspot/Makefile

vfs_donmount(struct thread *td, uint64_t fsflags, struct uio *fsoptions)
          * If has_nonexport is true or the caller is not running within a
          * vnet prison that can run mountd(8), set jail_export false.
          */
         if (has_nonexport || !jailed(td->td_ucred) ||
             !prison_check_nfsd(td->td_ucred))
                 jail_export = false;
 
         error = vfs_domount(td, fstype, fspath, fsflags, jail_export, &optlist);
-        if (error == ENOENT) {
+        if (error == ENODEV) {
                 error = EINVAL;
                 if (errmsg != NULL)
                         strncpy(errmsg, "Invalid fstype", errmsg_len);
                 goto bail;
         }
 
         /*
          * See if we can mount in the read-only mode if the error code suggests
if (error) {
                 free(fstype, M_TEMP);
                 return (error);
         }
 
         AUDIT_ARG_TEXT(fstype);
         vfsp = vfs_byname_kld(fstype, td, &error);
         free(fstype, M_TEMP);
         if (vfsp == NULL)
-                return (ENOENT);
+                return (EINVAL);
         if (((vfsp->vfc_flags & VFCF_SBDRY) != 0 &&
             vfsp->vfc_vfsops_sd->vfs_cmount == NULL) ||
             ((vfsp->vfc_flags & VFCF_SBDRY) == 0 &&
             vfsp->vfc_vfsops->vfs_cmount == NULL))
                 return (EOPNOTSUPP);
 
         ma = mount_argsu(ma, "fstype", uap->type, MFSNAMELEN);
         ma = mount_argsu(ma, "fspath", uap->path, MNAMELEN);

head/audio/spotify-tui/Makefile

vfs_donmount(struct thread *td, uint64_t fsflags, struct uio *fsoptions)
          * If has_nonexport is true or the caller is not running within a
          * vnet prison that can run mountd(8), set jail_export false.
          */
         if (has_nonexport || !jailed(td->td_ucred) ||
             !prison_check_nfsd(td->td_ucred))
                 jail_export = false;
 
         error = vfs_domount(td, fstype, fspath, fsflags, jail_export, &optlist);
-        if (error == ENOENT) {
+        if (error == ENODEV) {
                 error = EINVAL;
                 if (errmsg != NULL)
                         strncpy(errmsg, "Invalid fstype", errmsg_len);
                 goto bail;
         }
 
         /*
          * See if we can mount in the read-only mode if the error code suggests
if (error) {
                 free(fstype, M_TEMP);
                 return (error);
         }
 
         AUDIT_ARG_TEXT(fstype);
         vfsp = vfs_byname_kld(fstype, td, &error);
         free(fstype, M_TEMP);
         if (vfsp == NULL)
-                return (ENOENT);
+                return (EINVAL);
         if (((vfsp->vfc_flags & VFCF_SBDRY) != 0 &&
             vfsp->vfc_vfsops_sd->vfs_cmount == NULL) ||
             ((vfsp->vfc_flags & VFCF_SBDRY) == 0 &&
             vfsp->vfc_vfsops->vfs_cmount == NULL))
                 return (EOPNOTSUPP);
 
         ma = mount_argsu(ma, "fstype", uap->type, MFSNAMELEN);
         ma = mount_argsu(ma, "fspath", uap->path, MNAMELEN);

head/audio/spotifyd/Makefile

vfs_donmount(struct thread *td, uint64_t fsflags, struct uio *fsoptions)
          * If has_nonexport is true or the caller is not running within a
          * vnet prison that can run mountd(8), set jail_export false.
          */
         if (has_nonexport || !jailed(td->td_ucred) ||
             !prison_check_nfsd(td->td_ucred))
                 jail_export = false;
 
         error = vfs_domount(td, fstype, fspath, fsflags, jail_export, &optlist);
-        if (error == ENOENT) {
+        if (error == ENODEV) {
                 error = EINVAL;
                 if (errmsg != NULL)
                         strncpy(errmsg, "Invalid fstype", errmsg_len);
                 goto bail;
         }
 
         /*
          * See if we can mount in the read-only mode if the error code suggests
if (error) {
                 free(fstype, M_TEMP);
                 return (error);
         }
 
         AUDIT_ARG_TEXT(fstype);
         vfsp = vfs_byname_kld(fstype, td, &error);
         free(fstype, M_TEMP);
         if (vfsp == NULL)
-                return (ENOENT);
+                return (EINVAL);
         if (((vfsp->vfc_flags & VFCF_SBDRY) != 0 &&
             vfsp->vfc_vfsops_sd->vfs_cmount == NULL) ||
             ((vfsp->vfc_flags & VFCF_SBDRY) == 0 &&
             vfsp->vfc_vfsops->vfs_cmount == NULL))
                 return (EOPNOTSUPP);
 
         ma = mount_argsu(ma, "fstype", uap->type, MFSNAMELEN);
         ma = mount_argsu(ma, "fspath", uap->path, MNAMELEN);