Differential D23844

Bring in various kgdb fixes for powerpc.
ClosedPublic
Actions

Authored by jhb on Feb 26 2020, 7:02 PM.

Tags

None

Referenced Files

	F175393870: D23844.id68849.diff
	Sat, Oct 10, 1:05 PM

	F175388826: D23844.id68865.diff
	Sat, Oct 10, 12:07 PM

	F175376059: D23844.diff
	Sat, Oct 10, 9:49 AM

	Unknown Object (File)
	Fri, Oct 9, 9:51 AM

	Unknown Object (File)
	Fri, Oct 9, 9:51 AM

	Unknown Object (File)
	Fri, Oct 9, 9:50 AM

	Unknown Object (File)
	Thu, Oct 8, 10:53 PM

	Unknown Object (File)
	Mon, Oct 5, 11:21 AM

Subscribers

Details

Reviewers

Commits

rP527234: Bring in various kgdb fixes for powerpc.

Summary

This merges in several fixes for kgdb on powerpc including fixing
backtraces and cross-debugging support.

Submitted by: luporl

Test Plan

poudriere bulk on stable/12 amd64

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Feb 26 2020, 7:02 PM

Herald added subscribers: mat, emaste. · View Herald TranscriptFeb 26 2020, 7:02 PM

Harbormaster completed remote builds in B29626: Diff 68849.Feb 26 2020, 7:02 PM

I know GDB 9 is released and I have a branch of kgdb based on the 9.x branch but wanted to get these in first before doing a patch to update to 9.1.

The arm change is just a compiler warning fix for an unused variable.

devel/gdb/Makefile
33 ↗	(On Diff #68849)	Oops, we don't need this bit (though it doesn't hurt).

pizzamig added inline comments.Feb 26 2020, 9:06 PM

devel/gdb/Makefile
33 ↗	(On Diff #68849)	actually it hurts. Can you please revert it? PREFIX is the prefix for the ports. This setting is designed for the base. Practically, we are moving the debug dir from /usr/lib/debug , where the base's debug symbols are stored to /usr/local/lib/debug that do not exist.

pizzamig added inline comments.Feb 26 2020, 9:11 PM

devel/gdb/Makefile
33 ↗	(On Diff #68849)	ups, sorry, I'm wrong, you're adding it, not changing it. Good to me

Please commit it

This revision is now accepted and ready to land.Feb 26 2020, 9:26 PM

Closed by commit rP527234: Bring in various kgdb fixes for powerpc. (authored by jhb). · Explain WhyFeb 27 2020, 1:01 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rP527234: Bring in various kgdb fixes for powerpc..

luporl mentioned this in D21946: [PPC] Fix kgdb symbol resolution.Feb 27 2020, 12:30 PM

luporl mentioned this in D22761: [PPC] Fix register context fetch from pcb.

Revision Contents
Changeset List

Path

Size

head/

devel/

gdb/

1 line

files/

extrapatch-kgdb

86 lines

kgdb/

arm-fbsd-kern.c

2 lines

22 lines

78 lines

Diff 68865

head/devel/gdb/Makefile

Loading...

head/devel/gdb/files/extrapatch-kgdb

Loading...

head/devel/gdb/files/kgdb/arm-fbsd-kern.c

Loading...

head/devel/gdb/files/kgdb/fbsd-kvm.c

Loading...

head/devel/gdb/files/kgdb/ppcfbsd-kern.c

Loading...