Page MenuHomeFreeBSD

Bring in various kgdb fixes for powerpc.
ClosedPublic

Authored by jhb on Feb 26 2020, 7:02 PM.

Details

Summary

This merges in several fixes for kgdb on powerpc including fixing
backtraces and cross-debugging support.

Submitted by: luporl

Test Plan
  • poudriere bulk on stable/12 amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb created this revision.Feb 26 2020, 7:02 PM
jhb added a comment.Feb 26 2020, 7:04 PM

I know GDB 9 is released and I have a branch of kgdb based on the 9.x branch but wanted to get these in first before doing a patch to update to 9.1.

The arm change is just a compiler warning fix for an unused variable.

devel/gdb/Makefile
33 ↗(On Diff #68849)

Oops, we don't need this bit (though it doesn't hurt).

pizzamig added inline comments.Feb 26 2020, 9:06 PM
devel/gdb/Makefile
33 ↗(On Diff #68849)

actually it hurts. Can you please revert it?

PREFIX is the prefix for the ports. This setting is designed for the base.
Practically, we are moving the debug dir from /usr/lib/debug , where the base's debug symbols are stored to /usr/local/lib/debug that do not exist.

pizzamig added inline comments.Feb 26 2020, 9:11 PM
devel/gdb/Makefile
33 ↗(On Diff #68849)

ups, sorry, I'm wrong, you're adding it, not changing it.
Good to me

pizzamig accepted this revision.Feb 26 2020, 9:26 PM

Please commit it

This revision is now accepted and ready to land.Feb 26 2020, 9:26 PM
This revision was automatically updated to reflect the committed changes.