Details
- Reviewers
kaktus - Group Reviewers
docs - Commits
- rS358548: sys/: Document few more sysctls.
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 29506 Build 27376: arc lint + arc unit
Event Timeline
sys/kern/kern_exec.c | ||
---|---|---|
135–136 | Use style(9) similar to the entry before, the documentation string should be in a separate line, using proper indentation of 4 spaces. | |
sys/kern/kern_shutdown.c | ||
170–171 | This should be four spaces and doc sting in a new line. | |
sys/kern/kern_synch.c | ||
98 | Here too. | |
sys/kern/sched_4bsd.c | ||
438 | And too. | |
sys/kern/sched_ule.c | ||
3130 | And too. | |
sys/kern/subr_kobj.c | ||
71 | And too :-) |
sys/kern/kern_exec.c | ||
---|---|---|
127 | Perhaps "Location of process' ps_strings structure" | |
132 | Perhaps "Top of process stack" (usrstack is the top, not the bottom of the stack, and even then we store various things on the stack such as argv[] and environment arrays before the actual stack used by main()) | |
135–136 | Perhaps "Stack memory permissions". This has the same value as the "prot" argument to mmap (bitmask of PROT_* constants), and the description of "prot" in mmap(2) is "permissions" | |
sys/kern/kern_synch.c | ||
98 | Might be nice to say what it is used for? I think it might be the scaling factor used for load average values, but haven't looked to see how userland (e.g. top or ps) uses this. | |
sys/kern/kern_umtx.c | ||
243 | s/Maximal/Maximum/? maybe s/one/each/ as well |