lang/rust: simplify plist generation
ClosedPublic
Actions

Authored by mikael on Feb 17 2020, 8:30 PM.

Details

Reviewers

Group Reviewers

Summary

I'm not sure why rust-installer-version/manifest-* were installed, but it doesn't seem to be needed.
Remove html/{.lock,.stamp}
Use ${DOCSDIR} instead of share/doc/rust

for rust-1.42.0

Test Plan

poudriere testport: ok
build all cargo consumers: ok on 12.1 amd64

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mikael created this revision.Feb 17 2020, 8:30 PM

Herald added a subscriber: mat. · View Herald TranscriptFeb 17 2020, 8:30 PM

The manifests are basically already a plist which post-install just transforms into our plist format. Not sure if we want to loosen control over it. The only downside I can see is that that files that are outside of the manifests will not be flagged as extra files by Poudriere.

lang/rust/Makefile
197–198	~~file~~
197–204	Only the first paragraph is interesting now.
214	What is INSTALLDIR?

tobik added inline comments.Feb 18 2020, 8:43 PM

lang/rust/Makefile
216–217	Could this not be merged into the previous sed?

mikael updated this revision to Diff 68558.Feb 19 2020, 8:06 PM

mikael edited the summary of this revision. (Show Details)

mikael added inline comments.

lang/rust/Makefile
197–204	the last one also?
214	should be PREFIX
216–217	I'm not able to merge the two SED

tobik added inline comments.Feb 20 2020, 1:07 PM

lang/rust/Makefile
197–204	¯\_(ツ)_/¯
216–217	Untested with lang/rust but ${FIND} ${STAGEDIR}${PREFIX} -not -type d \| \ ${SED} -E -e 's,^${STAGEDIR}${PREFIX}/,,' -e 's,(share/man/man[1-9]/.*\.[0-9]),\1.gz,' should work.