Page MenuHomeFreeBSD

lang/rust: simplify plist generation
ClosedPublic

Authored by mikael on Feb 17 2020, 8:30 PM.

Details

Reviewers
tobik
Group Reviewers
rust
Summary

I'm not sure why rust-installer-version/manifest-* were installed, but it doesn't seem to be needed.
Remove html/{.lock,.stamp}
Use ${DOCSDIR} instead of share/doc/rust

for rust-1.42.0

Test Plan

poudriere testport: ok
build all cargo consumers: ok on 12.1 amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

The manifests are basically already a plist which post-install just transforms into our plist format. Not sure if we want to loosen control over it. The only downside I can see is that that files that are outside of the manifests will not be flagged as extra files by Poudriere.

lang/rust/Makefile
197–198

file

197–204

Only the first paragraph is interesting now.

213

What is INSTALLDIR?

lang/rust/Makefile
215–216

Could this not be merged into the previous sed?

mikael edited the summary of this revision. (Show Details)
mikael added inline comments.
lang/rust/Makefile
197–204

the last one also?

213

should be PREFIX

215–216

I'm not able to merge the two SED

lang/rust/Makefile
197–204

¯\_(ツ)_/¯

215–216

Untested with lang/rust but

${FIND} ${STAGEDIR}${PREFIX} -not -type d | \
	${SED} -E -e 's,^${STAGEDIR}${PREFIX}/,,' -e 's,(share/man/man[1-9]/.*\.[0-9]),\1.gz,'

should work.

mikael edited the test plan for this revision. (Show Details)
mikael added inline comments.
lang/rust/Makefile
215–216

Thanks, I got confused with REINPLACE_CMD vs SED

This revision is now accepted and ready to land.Feb 27 2020, 3:24 PM