Page MenuHomeFreeBSD

Take LINKER_FREEBSD_VERSION from numerical field after dash
ClosedPublic

Authored by dim on Feb 15 2020, 12:31 AM.
Tags
None
Referenced Files
F132949468: D23691.id68561.diff
Tue, Oct 21, 10:53 AM
F132896248: D23691.id.diff
Mon, Oct 20, 11:16 PM
F132896241: D23691.id68344.diff
Mon, Oct 20, 11:15 PM
Unknown Object (File)
Mon, Oct 20, 1:07 PM
Unknown Object (File)
Sat, Oct 18, 10:31 PM
Unknown Object (File)
Sat, Sep 27, 3:18 AM
Unknown Object (File)
Tue, Sep 23, 7:17 AM
Unknown Object (File)
Sep 18 2025, 8:25 AM
Subscribers
None

Details

Summary

With COMPILER_FREEBSD_VERSION, we use a numeric value that we bump each
time we make a change that requires re-bootstrapping, but with the
linker variant, we instead take the entire part after "FreeBSD", as in
this example version output:

LLD 9.0.1 (FreeBSD c1a0a213378a458fbea1a5c77b315c7dce08fd05-1300006) (compatible with GNU linkers)

E.g., LINKER_FREEBSD_VERSION is currently being set to
"c1a0a213378a458fbea1a5c77b315c7dce08fd05-1300006". This means that
*any* new upstream lld version will cause re-bootstrapping.

We should only look at the numerical field we append after a dash
instead. This review attempts to make it so.

The only thing I am not happy about is the post-processing of awk output
in Makefile.inc1. I notice that our awk does not have gensub(), so it
can't substitute a numbered sub-regex with \1, \2, etc. Suggestions
welcome. :)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable