Page MenuHomeFreeBSD

x11/libxkbcommon: update to 0.10.0
ClosedPublic

Authored by jbeich on Fri, Feb 14, 2:59 PM.

Details

Reviewers
manu
Group Reviewers
x11
Commits
rP526224: x11/libxkbcommon: Update to 0.10
Summary

See ChangeLog changes and ABI. Other changes:

  • Switch to USES=meson after xkbcommon-0.8.4-30-g25cd67d
  • Drop USES=xorg-cat until it supports Meson build
  • Add DIST_SUBDIR and USES=pkgconfig to mimic USES=xorg-cat
Test Plan

Builds fine on:

  • 11.3 aarch64
  • 11.3 amd64
  • 11.3 armv6
  • 11.3 i386
  • 12.0 amd64
  • 12.0 i386
  • 12.1 aarch64
  • 12.1 amd64
  • 12.1 armv6
  • 12.1 armv7
  • 12.1 i386
  • 13.0 amd64
  • 13.0 i386
  • Base GCC 4.2.1 (mimics powerpc*, mips*, riscv64)
  • All 46 direct consumers on 11.3 amd64

Works fine on:

  • XKB_DEFAULT_RULES="evdev" XKB_DEFAULT_LAYOUT="us(dvp)" XKB_DEFAULT_OPTIONS="caps:ctrl_modifier,ctrl:nocaps"
  • games/openra + SDL_VIDEODRIVER=wayland
  • games/veloren (under Wayland)
  • multimedia/mpv (under Wayland)
  • www/firefox + MOZ_ENABLE_WAYLAND=1
  • x11-wm/cage
  • x11-wm/sway
  • x11/wev

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jbeich created this revision.Fri, Feb 14, 2:59 PM
jbeich edited the test plan for this revision. (Show Details)Fri, Feb 14, 3:03 PM

Where did the static libraries go?
I don't know if they are used, but an exp-run might be warranted if we remove them from the package.

jbeich edited the summary of this revision. (Show Details)Fri, Feb 14, 3:04 PM
jbeich updated this revision to Diff 68332.Fri, Feb 14, 6:30 PM
jbeich edited the test plan for this revision. (Show Details)
  • Pet portfmt

Where did the static libraries go?

According to upstream:

  • In autotools the default behavior is to install both static and shared versions of the libraries. In meson the user must choose exactly one (using -Ddefault_library=static/shared).

I don't know if they are used, but an exp-run might be warranted if we remove them from the package.

All 46 consumers built fine on 11.3 amd64. Do you still need an exp-run?

manu added a subscriber: manu.Sat, Feb 15, 2:03 PM

I'm not super familiar with this lib and how it works but we compile it with --disable-wayland so I'm wondering why this swich is set and how it worked for you. Could you explain more on this ?
Otherwise patch looks good to me.

  • libwayland + wayland-protocols dependency is only used to build test/interactive-wayland.c which is not installed
  • libxkbcommon is mainly used by Wayland consumers but sometimes not (e.g., i3-gaps, qemu, kodi+gbm, libskk)
manu accepted this revision as: manu.Sat, Feb 15, 3:13 PM

Yeah Niclas directed me to the meson lines WRT wayland.
LGTM.

This revision is now accepted and ready to land.Sat, Feb 15, 3:13 PM
This revision was automatically updated to reflect the committed changes.