Page MenuHomeFreeBSD

ntb: Add Hygon Dhyana support
ClosedPublic

Authored by puwen_hygon.cn on Fri, Feb 7, 10:51 AM.

Details

Summary

Add support for Hygon NTB PCI device ID 0x145B in ntb_hw_amd driver.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

puwen_hygon.cn created this revision.Fri, Feb 7, 10:51 AM
mav added inline comments.Fri, Feb 7, 2:38 PM
sys/dev/ntb/ntb_hw/ntb_hw_amd.h
55 ↗(On Diff #67928)

Above constants were in upper case. What's about the second ID, does AMD kept that to themselves?

puwen_hygon.cn added inline comments.Sun, Feb 9, 11:31 AM
sys/dev/ntb/ntb_hw/ntb_hw_amd.h
55 ↗(On Diff #67928)

OK, will keep in upper case. Hygon does not have the second ID, please reference to:

http://pci-ids.ucw.cz/read/PC/1d94
puwen_hygon.cn edited the summary of this revision. (Show Details)

Keep the Hygon constants in upper case.

mav added inline comments.Fri, Feb 14, 2:58 PM
sys/dev/ntb/ntb_hw/ntb_hw_amd.h
55 ↗(On Diff #67928)

Once you mentioned, I see second AHCI ID there, while I've just committed patch with only one.

mav accepted this revision.Fri, Feb 14, 3:00 PM
This revision is now accepted and ready to land.Fri, Feb 14, 3:00 PM
This revision was automatically updated to reflect the committed changes.