ntb: Add Hygon Dhyana support
ClosedPublic
Actions

Authored by puwen_hygon.cn on Feb 7 2020, 10:51 AM.

Details

Reviewers

imp
cem
kib
mav

Commits

rS357920: Add support for Hygon NTB PCI device in ntb_hw_amd driver.

Summary

Add support for Hygon NTB PCI device ID 0x145B in ntb_hw_amd driver.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

puwen_hygon.cn created this revision.Feb 7 2020, 10:51 AM

mav added inline comments.Feb 7 2020, 2:38 PM

sys/dev/ntb/ntb_hw/ntb_hw_amd.h
55 ↗	(On Diff #67928)	Above constants were in upper case. What's about the second ID, does AMD kept that to themselves?

puwen_hygon.cn added inline comments.Feb 9 2020, 11:31 AM

sys/dev/ntb/ntb_hw/ntb_hw_amd.h
55 ↗	(On Diff #67928)	OK, will keep in upper case. Hygon does not have the second ID, please reference to: http://pci-ids.ucw.cz/read/PC/1d94

Keep the Hygon constants in upper case.

mav added inline comments.Feb 14 2020, 2:58 PM

sys/dev/ntb/ntb_hw/ntb_hw_amd.h
55 ↗	(On Diff #67928)	Once you mentioned, I see second AHCI ID there, while I've just committed patch with only one.

mav accepted this revision.Feb 14 2020, 3:00 PM

This revision is now accepted and ready to land.Feb 14 2020, 3:00 PM

Closed by commit rS357920: Add support for Hygon NTB PCI device in ntb_hw_amd driver. (authored by mav). · Explain WhyFeb 14 2020, 3:05 PM

This revision was automatically updated to reflect the committed changes.

mav added a commit: rS357920: Add support for Hygon NTB PCI device in ntb_hw_amd driver..

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

ntb/

ntb_hw/

ntb_hw_amd.h

3 lines

ntb_hw_amd.c

15 lines

Diff 68321

View Options

head/sys/dev/ntb/ntb_hw/ntb_hw_amd.h