Page MenuHomeFreeBSD

Improve implementation of install-missing-packages
ClosedPublic

Authored by 0mp on Feb 6 2020, 9:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 3, 5:08 AM
Unknown Object (File)
Tue, Mar 24, 4:24 AM
Unknown Object (File)
Sat, Mar 21, 5:16 AM
Unknown Object (File)
Fri, Mar 20, 5:46 PM
Unknown Object (File)
Mar 8 2026, 6:55 PM
Unknown Object (File)
Mar 8 2026, 12:56 PM
Unknown Object (File)
Mar 8 2026, 3:31 AM
Unknown Object (File)
Mar 8 2026, 1:18 AM
Subscribers

Details

Summary
Improve implementation of install-missing-packages

As suggested by mat@ in D23484, let's use a proper if statement here instead of
short-circuits operators.
Test Plan

Run make install-missing-packages in:

  • a port which has all the dependencies already installed
  • a port which is still missing some dependencies

Try all the above scenarios with the default SU_CMD and with SU_CMD= /usr/local/bin/sudo -E sh -c.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Mk/bsd.port.mk
4336 ↗(On Diff #67858)

Ah, no, I knew I saw something I did not like. Quote what you pass to echo.

$$(${ECHO} "$${_dirs}"
0mp planned changes to this revision.Feb 6 2020, 4:07 PM
0mp added inline comments.
Mk/bsd.port.mk
4336 ↗(On Diff #67858)

I should also use "ECHO_CMD" instead, right?

Mk/bsd.port.mk
4336 ↗(On Diff #67858)

yes

This revision was not accepted when it landed; it landed in state Changes Planned.Feb 6 2020, 4:44 PM
This revision was automatically updated to reflect the committed changes.