Page MenuHomeFreeBSD

RISC-V: un-ifdef vm.kvm_size and vm.kvm_free sysctls
ClosedPublic

Authored by mhorne on Feb 5 2020, 11:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 7 2024, 5:50 AM
Unknown Object (File)
Apr 30 2024, 7:45 AM
Unknown Object (File)
Apr 7 2024, 10:59 PM
Unknown Object (File)
Apr 7 2024, 7:09 PM
Unknown Object (File)
Mar 7 2024, 6:03 PM
Unknown Object (File)
Dec 19 2023, 11:12 PM
Unknown Object (File)
Nov 4 2023, 3:24 AM
Unknown Object (File)
Oct 23 2023, 7:59 AM
Subscribers

Details

Summary

While here, remove some trailing whitespace.

Test Plan

sysctl output:

root@qemu:~ # sysctl vm.kvm_size
vm.kvm_size: 34359738368
root@qemu:~ # sysctl vm.kvm_free
vm.kvm_free: 33460060160

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj added inline comments.
sys/riscv/riscv/pmap.c
1446 ↗(On Diff #67836)

While here, perhaps add a space around '|' and add CTLFLAG_MPSAFE. Otherwise Giant will be acquired around each call to the handler. There is some work in progress to invert the default behaviour wrt Giant, but adding the flag now will reduce the number of handlers that need to be audited.

This revision is now accepted and ready to land.Feb 6 2020, 3:09 AM

Add CTLFLAG_MPSAFE. Move sysctl description to a separate line.

This revision now requires review to proceed.Feb 10 2020, 12:32 AM
This revision is now accepted and ready to land.Feb 11 2020, 4:30 AM
This revision was automatically updated to reflect the committed changes.