Fix the !SMP case in sched_add().
ClosedPublic
Actions

Authored by markj on Feb 3 2020, 8:33 PM.

Tags

None

Referenced Files

	F154024340: D23492.id.diff
	Sat, Apr 25, 1:28 PM

	Unknown Object (File)
	Thu, Apr 16, 2:24 PM

	Unknown Object (File)
	Thu, Apr 16, 4:44 AM

	Unknown Object (File)
	Tue, Apr 14, 11:44 AM

	Unknown Object (File)
	Tue, Apr 14, 3:53 AM

	Unknown Object (File)
	Tue, Apr 14, 3:21 AM

	Unknown Object (File)
	Sun, Apr 12, 12:57 PM

	Unknown Object (File)
	Sun, Apr 5, 10:30 PM

View All Files

Subscribers

imp

Details

Reviewers

jeff
kib

Commits

rS357473: Fix the !SMP case in sched_add() after r355779.

Summary

If the thread's lock is already that of the runqueue, don't recurse on
the queue lock.

Test Plan

Fixes a panic on boot that I hit while trying to reproduce an unrelated problem.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Feb 3 2020, 8:33 PM

Harbormaster completed remote builds in B29146: Diff 67741.Feb 3 2020, 8:33 PM

markj edited the test plan for this revision. (Show Details)Feb 3 2020, 8:35 PM

markj added reviewers: jeff, kib.

kib accepted this revision.Feb 3 2020, 8:43 PM

This revision is now accepted and ready to land.Feb 3 2020, 8:43 PM

I thought I tested !SMP but maybe I just built it. This LGTM.

Looking at this I should really just add srqflags to thread_lock_set and possibly something similar to thread_lock_block().

Closed by commit rS357473: Fix the !SMP case in sched_add() after r355779. (authored by markj). · Explain WhyFeb 3 2020, 10:49 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS357473: Fix the !SMP case in sched_add() after r355779..

Herald added a subscriber: imp. · View Herald TranscriptFeb 3 2020, 10:49 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

sched_ule.c

12 lines

Diff 67748

View Options

Fix the !SMP case in sched_add().ClosedPublicActions