Page MenuHomeFreeBSD

databases/grass7: add SONAME and use new path for graphics/qgis*
ClosedPublic

Authored by lbartoletti on Feb 2 2020, 12:49 PM.
Tags
None
Referenced Files
F167607694: D23470.diff
Sun, Aug 23, 2:26 AM
F167607686: D23470.diff
Sun, Aug 23, 2:26 AM
F167579168: D23470.diff
Sat, Aug 22, 8:26 PM
Unknown Object (File)
Wed, Aug 12, 8:35 AM
Unknown Object (File)
Sat, Aug 8, 4:03 PM
Unknown Object (File)
Sat, Aug 8, 10:55 AM
Unknown Object (File)
Sat, Aug 1, 5:43 PM
Unknown Object (File)
Fri, Jul 31, 4:09 AM
Subscribers

Details

Summary

databases/grass7: add SONAME and use new path for graphics/qgis*

Test Plan
  • portlint: OK (unrevelant warnings)
  • testport: OK (poudriere: 11/12/13, i386/amd64) [1]

[1] for databases/grass7 only 12amd64 for graphics/qgis and graphics/qgis-ltr

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks good to me.

graphics/qgis/files/patch-cmake_FindGRASS.cmake
10 ↗(On Diff #67663)

^ Unrelated to this review: you should probably sed in the value of ${LOCALBASE} instead of a hardcoded /usr/local.

This revision is now accepted and ready to land.Feb 4 2020, 6:37 AM
graphics/qgis/files/patch-cmake_FindGRASS.cmake
10 ↗(On Diff #67663)

I wonder if we can replace it by CMAKE_INSTALL_PREFIX instead.

lbartoletti added inline comments.
graphics/qgis/files/patch-cmake_FindGRASS.cmake
10 ↗(On Diff #67663)

It works, but it's a bad idea :)